search

PreferredAI / cornac

A Comparative Framework for Multimodal Recommender Systems
https://cornac.preferred.ai
Apache License 2.0
868 stars 142 forks source link

[BUG] Crash when using cornac with Numpy 2.0 #628

Closed quentinhaenn closed 3 months ago

quentinhaenn commented 3 months ago

Description

Cornac cannot work with Numpy 2.0. Error message: "A module that was compiled using NumPy 1.x cannot be run in NumPy 2.0.0 as it may crash. To support both 1.x and 2.x versions of NumPy, modules must be compiled with NumPy 2.0. Some module may need to rebuild instead e.g. with 'pybind11>=2.12'."

In which platform does it happen?

MacBook with ARM platform (M1) MacOS 14.5 Python 3.12

How do we replicate the issue?

Simply install cornac using pip install cornac and having numpy 2.0.0, then run: from cornac.data import Reader, Dataset

Rollback to numpy 1.26 solve the issue.

Expected behavior (i.e. solution)

Expected cornac to run with the new major version of Numpy.

tqtg commented 3 months ago

Thanks for reporting the issue. We're currently working towards making Cornac compatible with Numpy 2.0. In the meantime, we can rollback to Numpy 1.xx as you've suggested.

quentinhaenn commented 3 months ago

Thanks for the quick reply. I suggest pointing it out in installation process and in pyproject.toml or setup.py depending on which one you're using (with dependencies reporting numpy<=1.26until you make the proper migration to Numpy 2.0

Thank again !

tqtg commented 3 months ago

We're working on that and it'll be fixed soon in #627

darrylong commented 1 month ago

This has been fixed with the release of Cornac 2.2.2.