search

PreibischLab / BigStitcher

ImgLib2/BDV implementation of Stitching for large datasets
GNU General Public License v2.0
64 stars 14 forks source link

Snake Left&Down in MoveTilesOfAngle0 dialog actually arranges the tiles in Snake Up&Right #117

Open templiert opened 1 year ago

templiert commented 1 year ago

the live BDV display along the Regular Grid Option dialog shows me that the ordering of my 2D grid is the 3rd snake item (Snake: Left & Down). I also double-checked by hand, visiting the tiles with ascending tile number order: my grid is indeed a Snake: Left & Down (the Tile number pattern was correctly recognized in a previous dialog).

image

but if I use the following argument in Define dataset ... move_tiles_to_grid_(per_angle)?=[Move Tile to Grid (Macro-scriptable)] grid_type=[Snake: Left & Down]

then it instead arranges the grid as if I had clicked on the 6th snake item (supposedly Snake: Up & Right)

image

I reasoned that the relevant clue might be that the working order was the 3rd snake option in the Regular Grid Option. So I chose the 3rd snake option in the Move Tiles of Angle 0 dialog (Snake: Right & Up) and it worked. So there is a discrepancy. image

I believe there would then be a mix up somewhere in the GridPresets here? I could not quickly find the code of the Regular Grid Option dialog, but it looks suspicious that the ordering of the drop-down menu of Move Tiles of Angle 0 does not match the ordering of the snake pictures from left to right of the Regular Grid Option dialog (on the other hand it would be suspicious too that I'm the first one to notice this, but I triple-checked and the mix up seems to hold...)

hoerldavid commented 1 year ago

Dear @templiert ,

Thanks for bringing this to our attention. I had recently noticed strange behavior there as well.

I have removed an inconsistent double definition of icons for the interactive GUI and macro-scriptable dialog and re-checked that the actual arrangements correspond to the icon & description in the following commits: https://github.com/PreibischLab/BigStitcher/commit/b666a3da62d8119619246f4418cfe40eeed52c61, https://github.com/PreibischLab/multiview-reconstruction/commit/97eeb35cf7320e1cf543ae8cdd9c03f699760fa0

Sorry for the confusion, I probably did not check all possibilities when I first wrote this part.

Best, David

templiert commented 1 year ago

Ha, great, thanks @hoerldavid, happy it helped. Don't be sorry, we are thankful for this great tool.