PreibischLab / BigStitcher

ImgLib2/BDV implementation of Stitching for large datasets
GNU General Public License v2.0
68 stars 14 forks source link

Problem turning on RegistrationExplorer #18

Closed ptillberg closed 6 years ago

ptillberg commented 6 years ago

If I turn on RegistrationExplorer, then switch to Stitching mode and back to Multiview mode, I cannot turn on Registration Explorer again. There are no error messages--it just doesn't launch. Closing and re-opening BigStitcher does not help. I have to close and re-open ImageJ before I can re-launch RegistrationExplorer. I am able to turn RegistrationExplorer on and off repeatedly if I do so without leaving Multiview mode.

StephanPreibisch commented 6 years ago

Hi @ptillberg, I also experienced that, but only on Linux and could so far not reproduce it. I think this might be related to javafx @hoerldavid used to implement it. Do you also use Linux?

ptillberg commented 6 years ago

Hi Stephan and David,

I am running Windows 7 Professional. My Java version is 1.8.0_171. Not sure if that helps--let me know if there's any other information you need!

-Paul

On Thu, Jul 5, 2018 at 8:23 AM Stephan Preibisch notifications@github.com wrote:

Hi @ptillberg https://github.com/ptillberg, I also experienced that, but only on Linux and could so far not reproduce it. I think this might be related to javafx @hoerldavid https://github.com/hoerldavid used to implement it. Do you also use Linux?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PreibischLab/BigStitcher/issues/18#issuecomment-402704516, or mute the thread https://github.com/notifications/unsubscribe-auth/Am8ktWYXBBom3CRq1nyGIDA0e3jw1_Wdks5uDgUjgaJpZM4VC8SE .

hoerldavid commented 6 years ago

Hi @ptillberg & @StephanPreibisch,

I could reproduce the bug on my Mac as well and I think I found the solution: https://github.com/PreibischLab/multiview-reconstruction/commit/5bfa64f91dc1bcd4bd74e1bb81a0db38e44e0ee2

As suspected, JavaFX is the culprit: When we first open the registration explorer, the JFX platform is initialized and once we switch the mode, it is implicitly shut down because all parent UI elements are closed. Apparently, one cannot restart it once it has terminated and trying to open the registration explorer again will cause a deadlock in that thread (for the user, it looks as if nothing happens at all).

There is the option of turning off the implicit shutdown and that solves the problem for me. Let me know if solves the problem for you as well.

Best, David