search

PreibischLab / RS-FISH

Tool for precise, interactive, fast and scalable FISH spot detection
GNU General Public License v2.0
45 stars 14 forks source link

Update EJML #26

Open kephale opened 10 months ago

kephale commented 10 months ago

We got a request on the forum to update EJML: https://forum.image.sc/t/how-to-load-a-specific-library-in-fiji/87468/8

It looks like the EJML dependency is coming from: https://github.com/PreibischLab/FunctionFit/blob/master/pom.xml and only one file seems to need changes: https://github.com/PreibischLab/FunctionFit/blob/cf3735ccd47db4956b29f589b90f8acfe0a6f3d6/src/main/java/fit/circular/Ellipse.java#L39

Attn: @StephanPreibisch @mzouink CC: @NicoKiaru

imagejan commented 10 months ago

I opened https://github.com/PreibischLab/FunctionFit/pull/1.

To avoid having to add dependency exclusions, this should be coordinated with the update to jitk-tps (a transitive dependency of FunctionFit) in pom-scijava to avoid clashing artifacts.

imagejan commented 10 months ago

See also https://github.com/saalfeldlab/jitk-tps/commit/109d3ac2a8d6723fc90722c213c63736b054c82f for @bogovicj's changes to jitk-tps.