PreibischLab / RS-FISH

Tool for precise, interactive, fast and scalable FISH spot detection
GNU General Public License v2.0
45 stars 14 forks source link

Spot Z position is not set in Roi Manager #6

Open CellKai opened 3 years ago

CellKai commented 3 years ago

Hi, I noticed that when adding the spot ROIs to the Roi Manager, their Z-position is not set explicitly, which can lead to this information getting lost in some cases, see related image.sc forum thread: https://forum.image.sc/t/rois-added-to-roi-manager-by-macro-do-not-maintain-all-properties/37533/5

Example issue: Run RS fish including"add ROIs to RoiManager", then save the image using Bio-Formats as ome.tif including the ROIs.

This issue can be solved by setting the spots z positions explicitly by adding a line in RS-FISH/src/main/java/gui/Radial_Symmetry.java after line 344 https://github.com/PreibischLab/RS-FISH/blob/9c3521e87fdf5aa00ff926a2dc71010a5fc89734/src/main/java/gui/Radial_Symmetry.java#L344 e.g.: p.setPosition( 1 + (int)Math.round( spot.getDoublePosition( 2 ) ) );