search

PremierLangage / premierlangage

Server for auto-evaluating exercices
Other
18 stars 9 forks source link

[BUG] Same file in different split spaces are closed together in the editor #422

Open fwjmath opened 3 years ago

fwjmath commented 3 years ago

Reproduction Steps to reproduce:

  1. Open some file in the editor.
  2. Press Ctrl-rightarrow. If Issue PremierLangage/platon-front#62 is not fixed, then it should split the current editing space into two halves, each containing the same file.
  3. Close the file on either side.

Expected Behavior It should only close one copy of the file, leaving the other open.

Actual Behavior The other one is also closed.

Comments This behavior is not intuitive, as we expect different editing spaces to act independently.

mciissee commented 3 years ago

Sorry but this repository is linked to the next major version (1.0.0) of platform, the issue you are describing here is related to the editor of the current version. All the issues related to the current version (0.7.4) should be created on the repository https://github.com/PremierLangage/premierlangage.

In any case I will move this issue to the right repository now and close it once the issue will be resolved.

nheir commented 1 year ago

This lines in EditorGroup.close look suspicious as it requests the editor to close all occurrences of the resource.

https://github.com/PremierLangage/premierlangage/blob/1f20333ed4c8d93bf49f4ba330b37b492e19360d/frontend/editor/src/app/pages/editor/shared/models/editor-groups.model.ts#L277-L278