search

PresConsUIUC / PSAP

Home of the Preservation Self-Assessment Program application.
https://psap.library.illinois.edu/
Other
4 stars 1 forks source link

Revert delete action on PSAP? #340

Closed miriamcenteno closed 8 years ago

miriamcenteno commented 8 years ago

PSAP user deleted repository by mistake. Can it be restored? See below:

From: Sent: Wednesday, March 9, 2016 12:10 PM To: UI-LIB-PSAP Subject: revert delete action on PSAP?

Hello:

I just accidentally deleted the repository location I had all of my resources in… is there any way we can revert this mistake?? Please help!

Sincerely,

adolski commented 8 years ago

(Response via email)

miriamcenteno commented 8 years ago

Can these three things be done?

  1. Obtain a dump of the file from last night’s back up- Jennifer is willing to try to ID the records for her institution
  2. Get the records back into the system- we are not sure how we could do it
  3. Add an “are you SURE you want to delete this [location, record, institution]” pop up to all delete buttons
adolski commented 8 years ago

Re: 1 and 2: The backups are SQL files containing all of the commands to load all of the data into an empty database. They are not in "human" format. Without getting into all of the details, it would be a horrendous job.

Re: 3: I do sympathize with the user here, and I am open to ideas on making the delete process safer, but no matter what we do, we should expect that mistaken deletes are going to happen from time to time. All delete buttons already have confirmation popups, and these can protect against accidental clicks, but it's not really possible to ward off intentional clicks that the user finds to be mistaken after the fact. (Which is why Windows has a "Recycle Bin," for example.)

jhain commented 8 years ago

Thanks, Alex. OK, so the user in question actually clicked “delete location” and then confirmed the delete? (she asked for such a function to be added, which made me think that she did not confirm the delete). I agree that if this is already in place, we don’t need three levels of delete confirmation. How had would it be, though, to throw in something like this in the confirmation/warning popup?

“are you SURE you want to delete this location? Doing so will delete XX items”

From: adolski [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 9:43 AM To: PresConsUIUC/PSAP Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

Re: 1 and 2: The backups are SQL files containing all of the commands to load all of the data into an empty database. They are not in "human" format. Without getting into all of the details, it would be a horrendous job.

Re: 3: I do sympathize with the user here, and I am open to ideas on making the delete process safer, but no matter what we do, we should expect that mistaken deletes are going to happen from time to time. All delete buttons already have confirmation popups, and these can protect against accidental clicks, but it's not really possible to ward off intentional clicks that the user finds to be mistaken after the fact. (Which is why Windows has a "Recycle Bin," for example.)

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194912495&d=BQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=VmdTHodLILmRa-mKuNJG6pXvAPSt1Xuzf4ocbYKHlTE&m=5xJkPWwTSWSksMRIb8sC1cGWRVqJODThhbz9_QRTIpk&s=ufcwYNytzZuQPlae3KP6uVCDQG6GAT1v3lsFCncXW6k&e=.

adolski commented 8 years ago

The popups currently say, "Are you sure you want to delete this (repository/location/resource)?"

I could add some all-caps scare text after that.

jhain commented 8 years ago

Sure, let’s scare the wits out of them. In the meantime, Miriam, do you want to write to the user and say that to the best of our knowledge she DID click on the “are you sure” message to confirm the delete? Or do you want me to have the pleasure ☺

J

From: adolski [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:20 PM To: PresConsUIUC/PSAP Cc: Teper, Jennifer Hain Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

The popups currently say, "Are you sure you want to delete this (repository/location/resource)?"

I could add some all-caps scare text after that.

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194986925&d=BQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=VmdTHodLILmRa-mKuNJG6pXvAPSt1Xuzf4ocbYKHlTE&m=WBaR9q6jVRTqAOtDL53ig2hicCEzAuhlC6o6oST7WWI&s=Tj3LO1BP0Qx9Lhtw-EMw2WvswsREi1pWQXoeoKplaCU&e=.

miriamcenteno commented 8 years ago

Jennifer,

I think that it might come better from you. I also think that we may have to explain to people that recovering their data is not possible so that they are not expecting it’s restoration. Perhaps we should encourage them to generate/ download frequent reports. I am not familiar enough with PSAP enough to know if people can back up their own data.

Miriam

From: jhain [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:25 PM To: PresConsUIUC/PSAP PSAP@noreply.github.com Cc: Centeno, Miriam mcenteno@illinois.edu Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

Sure, let’s scare the wits out of them. In the meantime, Miriam, do you want to write to the user and say that to the best of our knowledge she DID click on the “are you sure” message to confirm the delete? Or do you want me to have the pleasure ☺

J

From: adolski [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:20 PM To: PresConsUIUC/PSAP Cc: Teper, Jennifer Hain Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

The popups currently say, "Are you sure you want to delete this (repository/location/resource)?"

I could add some all-caps scare text after that.

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194986925&d=BQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=VmdTHodLILmRa-mKuNJG6pXvAPSt1Xuzf4ocbYKHlTE&m=WBaR9q6jVRTqAOtDL53ig2hicCEzAuhlC6o6oST7WWI&s=Tj3LO1BP0Qx9Lhtw-EMw2WvswsREi1pWQXoeoKplaCU&e=.

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194989364&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=77QbxbLPLHbWTt_5Ss1IS5t-BOKviu-XTQA3ZdDV5Rg&m=t_j3NPkIKl-NXH-0vpLMgYaErYt9IqiFZls5QykpjiA&s=X0mgdRQan2CwmCNCNC_McyCtYkh3whAdpoL7DrHdFB4&e=.

jhain commented 8 years ago

They can do data dumps, but it wouldn’t be easy to get it back into the PSAP. more feasible it sounds like than from the SQL back up, but still a royal pain in the bottom from the resultant CSV.

But yes, I will add this to the online documentation so that it’s up there. And I will write back to the user.

Jennifer

From: miriamcenteno [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:31 PM To: PresConsUIUC/PSAP Cc: Teper, Jennifer Hain Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

Jennifer,

I think that it might come better from you. I also think that we may have to explain to people that recovering their data is not possible so that they are not expecting it’s restoration. Perhaps we should encourage them to generate/ download frequent reports. I am not familiar enough with PSAP enough to know if people can back up their own data.

Miriam

From: jhain [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:25 PM To: PresConsUIUC/PSAP PSAP@noreply.github.com Cc: Centeno, Miriam mcenteno@illinois.edu Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

Sure, let’s scare the wits out of them. In the meantime, Miriam, do you want to write to the user and say that to the best of our knowledge she DID click on the “are you sure” message to confirm the delete? Or do you want me to have the pleasure ☺

J

From: adolski [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:20 PM To: PresConsUIUC/PSAP Cc: Teper, Jennifer Hain Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

The popups currently say, "Are you sure you want to delete this (repository/location/resource)?"

I could add some all-caps scare text after that.

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194986925&d=BQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=VmdTHodLILmRa-mKuNJG6pXvAPSt1Xuzf4ocbYKHlTE&m=WBaR9q6jVRTqAOtDL53ig2hicCEzAuhlC6o6oST7WWI&s=Tj3LO1BP0Qx9Lhtw-EMw2WvswsREi1pWQXoeoKplaCU&e=.

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194989364&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=77QbxbLPLHbWTt_5Ss1IS5t-BOKviu-XTQA3ZdDV5Rg&m=t_j3NPkIKl-NXH-0vpLMgYaErYt9IqiFZls5QykpjiA&s=X0mgdRQan2CwmCNCNC_McyCtYkh3whAdpoL7DrHdFB4&e=.

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194991853&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=VmdTHodLILmRa-mKuNJG6pXvAPSt1Xuzf4ocbYKHlTE&m=frHUNzTdTwpDHDILs0QaWPRpF8V7GMJVIGhbk3nZkj8&s=u8AR8aLdpL1WMD4lp9OMkMAouNSQXG6AAj6SADb25AU&e=.

adolski commented 8 years ago

Open for feedback:

Delete institution (admins only)

Current

Deleting this institution will delete ALL of its repositories, locations, and resources along with it. Are you sure you want to do this?

New

Same

Delete repository

Current

Deleting this repository will delete all locations and resources it contains. Are you sure you want to delete this repository?'

New

Deleting this repository will delete all locations and resources it contains. Are you sure you want to delete this repository?'

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

Delete location

Curren

Deleting this location will also delete all resources it contains. Are you sure you want to delete this location?

New

Deleting this location will also delete all resources it contains. Are you sure you want to delete this location?

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

Delete resource

Current

Are you sure you want to delete this resource?

New

Are you sure you want to delete this resource? Any child resources will also be deleted.

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

miriamcenteno commented 8 years ago

I especially like the skull & bones in the extra warning. Should give them pause!

From: adolski [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:42 PM To: PresConsUIUC/PSAP PSAP@noreply.github.com Cc: Centeno, Miriam mcenteno@illinois.edu Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

Open for feedback:

Delete institution (admins only) Current

Deleting this institution will delete ALL of its repositories, locations, and resources along with it. Are you sure you want to do this?

New

Same

Delete repository Current

Deleting this repository will delete all locations and resources it contains. Are you sure you want to delete this repository?'

New

Deleting this repository will delete all locations and resources it contains. Are you sure you want to delete this repository?'

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

Delete location Curren

Deleting this location will also delete all resources it contains. Are you sure you want to delete this location?

New

Deleting this location will also delete all resources it contains. Are you sure you want to delete this location?

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

Delete resource Current

Are you sure you want to delete this resource?

New

Are you sure you want to delete this resource? Any child resources will also be deleted.

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194996094&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=77QbxbLPLHbWTt_5Ss1IS5t-BOKviu-XTQA3ZdDV5Rg&m=jvJNgrSuk6Zn4MtkA1ARKr4jvXq7YWuxVq9KYF30ruY&s=k4Or7kgMLoLOzpp19SSaxu1lsKzD4mvLTM-kC7RLgyo&e=.

jhain commented 8 years ago

Agreed.

From: miriamcenteno [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:45 PM To: PresConsUIUC/PSAP Cc: Teper, Jennifer Hain Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

I especially like the skull & bones in the extra warning. Should give them pause!

From: adolski [mailto:notifications@github.com] Sent: Thursday, March 10, 2016 12:42 PM To: PresConsUIUC/PSAP PSAP@noreply.github.com Cc: Centeno, Miriam mcenteno@illinois.edu Subject: Re: [PSAP] Revert delete action on PSAP? (#340)

Open for feedback:

Delete institution (admins only) Current

Deleting this institution will delete ALL of its repositories, locations, and resources along with it. Are you sure you want to do this?

New

Same

Delete repository Current

Deleting this repository will delete all locations and resources it contains. Are you sure you want to delete this repository?'

New

Deleting this repository will delete all locations and resources it contains. Are you sure you want to delete this repository?'

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

Delete location Curren

Deleting this location will also delete all resources it contains. Are you sure you want to delete this location?

New

Deleting this location will also delete all resources it contains. Are you sure you want to delete this location?

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

Delete resource Current

Are you sure you want to delete this resource?

New

Are you sure you want to delete this resource? Any child resources will also be deleted.

☠️ WARNING: THIS CANNOT BE UNDONE! ☠️

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194996094&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=77QbxbLPLHbWTt_5Ss1IS5t-BOKviu-XTQA3ZdDV5Rg&m=jvJNgrSuk6Zn4MtkA1ARKr4jvXq7YWuxVq9KYF30ruY&s=k4Or7kgMLoLOzpp19SSaxu1lsKzD4mvLTM-kC7RLgyo&e=.

— Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_PresConsUIUC_PSAP_issues_340-23issuecomment-2D194996788&d=BQMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=VmdTHodLILmRa-mKuNJG6pXvAPSt1Xuzf4ocbYKHlTE&m=xy_oKpj4Ex9KmbFkufNwXAOtORzQgZwotq4gfp0l-Us&s=pZZlrdMsDC8jtc5WoTz4GKM0iFKXn6PFQyh8kilQu84&e=.

elviaa commented 8 years ago

Hello, I am the PSAP user that experienced this --

I just retraced my steps by creating a dummy location and sub-resource within this dummy location. I originally wanted to delete a dummy sub-resource I was playing with within the location I deleted. My mistake was that I attempted to delete this record in this view (see below). deletepopup

There is no delete button to delete a single sub-resource in this view. There is the option to check individual sub-resources, but only to move them. One would have to first click on the sub-resource and then hit delete in this view. As you can see, this is an understandable action a user would attempt to do from this view. Also, the pop-up window looks so commonplace that I automatically confirmed the action without reading what the action will do.

Skulls and all caps for this pop-up will definitely help next time ;) Also, if possible, an Undo button?

Best, Elvia Arroyo-Ramirez

adolski commented 8 years ago

Thanks for illustrating this, @elviaa. I agree that the use case here is confusing. I will look into adding a "Delete Checked" button next to "Move Checked."

(An undo button is unfortunately difficult to achieve.)

adolski commented 8 years ago

Confirmation pop-up enhancements deployed; ended up using ⚠️ rather than ☠️ as it is a little more noticeable/clearer. Moved "Delete Checked" button to #341.