Temp and RH coming up as 0.0 in Score Summary

[spelczar]

@adolski @suhailsheth @jhain

Suhail noticed that temp and RH are both showing up as 0.0 in the Score Summary formula box. This happens with both old and new resources. Here is the example:

So, it appears that even though they should each be contributing 0.025 to the overall Resource score, the temp and RH are contributing nothing. Jennifer is going to look a little deeper into the math in the scoring matrix, but I want to at least get this issue on the radar since there isn't much time left on this project. Any chance this could just be a bug that is leaving out the temp and RH scoring in the summary scores??

Also FYI: The temp and RH questions are also weighted as 0.0 in the location QUESTIONS (see image below) - but I figured that was because the temp and RH scores are actually pulled from the Format Scores sheet of the question dependencies spreadsheet, not the Location sheet of the spreadsheet (since the temp and RH vary according to format, even though we ask about them in the "Location Assessment."

[adolski]

I found the bug that was causing the zero temp/RH scores. The fix has been deployed to psap-stage.

Re: your last paragraph, that is correct, AFAIK.

[jhain]

Thanks!!!!

From: adolski [mailto:notifications@github.com] Sent: Friday, November 11, 2016 11:32 AM To: PresConsUIUC/PSAP Cc: Teper, Jennifer Hain; Mention Subject: Re: [PresConsUIUC/PSAP] Temp and RH coming up as 0.0 in Score Summary (#359)

I found the bug that was causing the zero temp/RH scores. The fix has been deployed to psap-stage.

Re: your last paragraph, that is correct, AFAIK.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3Agithub.com_PresConsUIUC_PSAP_issues_359-23issuecomment-2D260010409&d=DQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=VmdTHodLILmRa-mKuNJG6pXvAPSt1Xuzf4ocbYKHlTE&m=Qo9m5j5v-gOfr_oYLzEmYV_JXAOn23RkmhNbKWKAKOs&s=sCUx3WCga9tmZZjpgs0uy2K-35gp6R-hD9TonOrWkJ8&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3Agithub.com_notifications_unsubscribe-2Dauth_AJRq5dl5mOU-2DXu2c5kCt-5Fc6iUIbie7tdks5q9KalgaJpZM4KuGHX&d=DQMCaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=VmdTHodLILmRa-mKuNJG6pXvAPSt1Xuzf4ocbYKHlTE&m=Qo9m5j5v-gOfr_oYLzEmYV_JXAOn23RkmhNbKWKAKOs&s=OFB79ushOzsmhsLpFm93tAYa7MX3sv0P1aVv-q-8m4U&e=.

[spelczar]

@adolski I'm checking to make sure this fix is coming through on the staged site, and for the most part have seen it working, except I found one weird instance where 0.0 still comes up on the RH of an item. Images below show two resources, both in the same location. You can see the 0.0 in the first image, and the second image is just an example of another item in the same location that appears to be working OK.

[adolski]

In the "Format Scores" tab of the assessment questions spreadsheet, "Archaeological Glass" has an RH score of 0 for min RH 0 and max RH 29.

Typo?

[spelczar]

Nope - that RH 0 for archaeological glass is actually correct. My bad. Closing this issue.

[spelczar]

@adolski @suhailsheth

The 0.0 temp scoring problem is back in a few places, which is weird, because the RH numbers seem to be working OK. Example: Location with 0-32F and 30-40%RH, archaeological nickel should come up with temp score of 0.33 but Scores appear in score summary as: Its temperature score is 0.0. Its relative humidity score is 100.0. (RH is correct)

Same thing is happening for stone materials - which are coming up with 0.0 temp score for 73-120F temp range, even though the spreadsheet has them scored as 0.33 for that range. The 0.0 score is also showing up on 0-33F temp score for Stone, even though 0-33F is scored as 0.33.

We have double checked the format scores sheet in the question dependencies spreadsheet. Could this be a bug/glitch?

[spelczar]

FYI: seems to be happening only with scores that should be 0.33.

[adolski]

@spelczar Can you post a psap-stage URL where this is happening?

[adolski]

@spelczar Nevermind, I see it. Fix attempt will be on psap-stage shortly.

[spelczar]

Sure try this: https://psap-stage.library.illinois.edu/resources/20 here's a screen capture in case that link doesn't work. The temp score is coming up as 0.0 and RH score as 75

here's a screen capture of the Location Assessment where you can see that the selected temp for that Location that the above chert object is in is 0-32F, with an RH of 30-40%.

According to the format scores sheet in the question dependencies spreadsheet, the score for 0-32F temp should be 0.33, not 0.0 (the 75 score for the 30-40% RH is correct)

Does that help? From what we can tell, the issue is only happening with 0.33 scores (changing 0.33 scores to 0.0 scores instead). So, it happens a lot with stone since 0.33 is the score at the top and bottom range of the stone temps; but I've also seen it happen with the 0.33 scores at the bottom range of the metal temps.

[spelczar]

oops, I was drafting my response when you send your "never mind" message. Ah well.

[adolski]

Thanks for the explanation, @spelczar. I believe this was caused by a bug. The fix has been deployed to psap-stage.

[spelczar]

thanks.