Assessment question seeding is unreliable

PresConsUIUC / PSAP

Home of the Preservation Self-Assessment Program application.

https://psap.library.illinois.edu/

Other

4 stars 1 forks source link

Assessment question seeding is unreliable #370

Closed adolski closed 7 years ago

adolski commented 7 years ago

https://github.com/PresConsUIUC/PSAP/blob/02a28eb70f603f75c9c075496854bafc0ae44d14/app/models/assessment_question_importer.rb#L135

AssessmentSection.find_by_name() is unreliable as multiple instances may have the same name. Figure out a way around this, and consider replacing AssessmentSection with a constant.