search

PressCrew / infinity-cbox

A fork of the Infinity theme for developing the official CBOX theme
GNU General Public License v2.0
1 stars 1 forks source link

Fix strict standards warnings and notices #1

Closed r-a-y closed 9 years ago

r-a-y commented 9 years ago

Hi Marshall,

Here's a PR that fixes some strict standards warnings and notices.

Commit f2612fc can be considered a hack, but I do not know enough about the ICE stack to address this properly. Feel free to fix this the right way :)

MrMaz commented 9 years ago

Are you seeing the wp_register_*() errors as PHP notices, or are they showing up in one of the theme developer plugin logs?

r-a-y commented 9 years ago

Are you seeing the wpregister*() errors as PHP notices, or are they showing up in one of the theme developer plugin logs?

PHP notices when WP_DEBUG is set to true.

MrMaz commented 9 years ago

I think I have the register stuff figured out. It's yet another thing that WordPress changed the rules on. You used to be allowed to register styles and scripts anytime you want, and then enqueue them later... now they are being strict about even registering them early.

I just need to monkey with the api code so it calls the WP register scripts later.

r-a-y commented 9 years ago

Don't you just :heart: WordPress?

MrMaz commented 9 years ago

The following fixes were made to Infinity core and merged into this repo:

Strict standards: 40345890b60a4520463a282d1db355f96b9ea04c 9cf2d5fab87fc044540db472fa5f5e44f338eedc

Asset registration issues: 8c036deb568c6c930acbfb2c0c45beafc34a69d2 a0262f84292600cbb7c4cee59072134f23bc1dbd

Thanks Ray ;)