search

PressForward / pressforward

PressForward is a free plugin that provides an editorial workflow for content aggregation and curation within the WordPress dashboard. It is designed for bloggers and editorial teams who wish to collect, discuss, and share content from a variety of sources on the open web.
GNU Affero General Public License v3.0
120 stars 22 forks source link

Trash collection doesn't work as expected #1113

Closed boonebgorges closed 1 year ago

boonebgorges commented 1 year ago

Describe the bug Per report from PF advisory board, trash collection doesn't work as expected.

See also #191

boonebgorges commented 1 year ago

It appears that I had a hand in writing the delete-queue system. See #604, fa227c863ea209d264065acb20875f6936e377b8.

Looking at that system now, I suspect that the weak point is the "self-ping" that the system uses for background-processing of item deletion. In my experience, these kinds of requests are pretty fragile across server environments. I've rewritten the implementation to use a cron job instead. The job runs hourly, and by default it will delete 25 items at a time. This probably means that items in the delete queue will end up hanging out a bit longer than previously, but given our techniques for hiding queued-for-deletion items from various feeds, I don't expect this to be a major issue.

For the time being, I've left the basics of the queue-for-deletion system in place.

We'll roll this out and see if folks are still reporting problems. If so, I'll need to get more info for further debugging. For the time being, I'll mark the current ticket resolved.