search

Pressio / pressio

core C++ library
Other
45 stars 7 forks source link

traits: restructure container type traits #418

Closed mzuzek closed 2 years ago

mzuzek commented 2 years ago

This PR is a new version of container type traits refactoring started on #359 driven by requirements and conclusions specified in https://github.com/Pressio/pressio/issues/356#issuecomment-1234062162.

fnrizzi commented 2 years ago

@mzuzek i think after fixing my last comments we should be good to go. but one other thing: can you please verify the tests and ensure we are testing the traits properly?

mzuzek commented 2 years ago

@fnrizzi I've reviewed the tests and added negative identification checks on https://github.com/Pressio/pressio/pull/418/commits/7b8a378fd8656ed79602ff3b080396566c10361e (with is_dense_col_major_matrix_eigen from fd27a67e94a5bc76a54a154a3127d16837924971). Also rebased the branch on current develop.

mzuzek commented 2 years ago

@fnrizzi Thank you for your reviews and comments!

fnrizzi commented 2 years ago

Thanks for doing all this work!!