search

Pressio / pressio

core C++ library
Other
45 stars 7 forks source link

488 add basic backtrack line search #495

Closed eparish1 closed 1 year ago

eparish1 commented 1 year ago

A basic backtrack search has been added along with a test for Newton Raphson and Gauss-Newton. The tests are based on a 2-component nonlinear system that uses an incorrect Jacobian to imitate a system where a line search is needed. There is also a unit test that @fnrizzi put together that tests the updater itself.

fnrizzi commented 1 year ago

@eparish1 can we find a name more expressive than "basic backtrack"? to convey the main feature of this is to find a step size that does not increase the residual. i don't know if this has a common name but it would be nice to express that somehow

fnrizzi commented 1 year ago

thanks @eparish1 for doing this, the patience with my comments and answering everything :) if you just fix the thing about the rootname in the test file then i will merge it

fnrizzi commented 1 year ago

did you fix it? is this ready again?