search

Pressio / pressio

core C++ library
Other
45 stars 7 forks source link

ops: revise eigen matrix-vector product #496

Closed mzuzek closed 1 year ago

mzuzek commented 1 year ago

refs #446

fnrizzi commented 1 year ago

@mzuzek is this ready? if not, can you make it draft until it is ready?

mzuzek commented 1 year ago

@fnrizzi

@mzuzek is this ready? if not, can you make it draft until it is ready?

sorry, it's ready for the review now

fnrizzi commented 1 year ago

@mzuzek this looks good, can you please fill in all the right assertions too? we have some here, but it would be good to complete all of them for every overload.

mzuzek commented 1 year ago

@mzuzek this looks good, can you please fill in all the right assertions too? we have some here, but it would be good to complete all of them for every overload.

which assertions are missing ?

edit: all extents related assertions seem to be in place

fnrizzi commented 1 year ago

checking if all extents are consistent between the various operands for all overloads