Pressio / pressio

core C++ library
Other
45 stars 7 forks source link

nonlinear solvers: fix armijo update location and alpha value #498

Closed eparish1 closed 1 year ago

eparish1 commented 1 year ago

Presently armijo will update even if we have a bad step. Line 149 of armijo should be moved into the block in lines 132-135. Otherwise we will take a step even if we can't find an acceptable step size and hit block 112-115. See backtrack lines 114-116 as an example.

In addition, I would vote for changing the alpha on line 112 to something more reasonable like 1e-3 or 1e-4.

This should be addressed before #425 #31