Pressio / pressio

core C++ library
Other
45 stars 7 forks source link

c++ 20 build casuses some warning for eigen 3.3.7 #511

Closed fnrizzi closed 6 months ago

fnrizzi commented 1 year ago

see this: https://github.com/Pressio/pressio/actions/runs/3604890996/jobs/6074723593

mzuzek commented 1 year ago

@fnrizzi I see two warnings replicated in different places:

Shall we disable the warnings ? Or try to upgrade Eigen to v3.4.0 in pressio-builder and see if that solves the issue ? I guess we could also fix Eigen to conform to C++20 if that doesn't work (they allow volunteers to contribute).

fnrizzi commented 1 year ago

all the C++20 is not high priority ,so let's skip this for now

fnrizzi commented 6 months ago

eigen was upgraded to 3.4 so this is not applicable any more