Pressio / pressio

core C++ library
Other
45 stars 7 forks source link

ops: epetra: revise rank-1 update #537

Closed mzuzek closed 1 year ago

mzuzek commented 1 year ago

Contents:

refs #448

mzuzek commented 1 year ago

@fnrizzi

Here in Epetra all coefficients have the same scalar_t type. Would you prefer to allow different coefficient types a_Type, b_Type, etc. like in Eigen ?

mzuzek commented 1 year ago

@fnrizzi

Here in Epetra all vectors have the same T type. Would you prefer to allow different vector types T1, T2, etc. like in Eigen ?

fnrizzi commented 1 year ago

@fnrizzi

Here in Epetra all coefficients have the same scalar_t type. Would you prefer to allow different coefficient types a_Type, b_Type, etc. like in Eigen ?

yes please!

fnrizzi commented 1 year ago

yes, we should have separate types T1, T2, etc

mzuzek commented 1 year ago

Hi @fnrizzi, I've added different coef/vector types, as we discussed, expanded unit tests to cover all execution paths and rebased on develop.

mzuzek commented 1 year ago

thanks @mzuzek for your review and comments!