ops: kokkos: revise rank-1 update

Pressio / pressio

core C++ library

Other

45 stars 7 forks source link

ops: kokkos: revise rank-1 update #542

Closed mzuzek closed 1 year ago

mzuzek commented 1 year ago

Contents:

[x] revised overload constraints
[x] added extent checks
[x] added explicit type casting for coefficients
[x] fixed NaN injection bug added related unit tests
[x] added expression unit tests with span and diag

refs #448

fnrizzi commented 1 year ago

can you please also fix the typo at the top:

struct _kokkosUpdateAdmissibleOperands
{
  /* make sure we don't pass const objects to be modified.
     In kokkos it is legal to modify const views, not for pressio wrappers. */
  static_assert
    (!std::is_const<T1>::value,
     "ops:product: cannot modify a const-qualified wrapper of a Kokkos view");

ops::product -> ops::update

mzuzek commented 1 year ago

Thanks @fnrizzi for your comments!

I've added Kokkos expression tests on 1242f193033a5e5a0c894e60bc8e9d1095b1ec44.