search

Pressio / pressio

core C++ library
Other
45 stars 7 forks source link

ops: assume 1 for overranked extents #591

Closed mzuzek closed 1 year ago

mzuzek commented 1 year ago

Based on https://github.com/Pressio/pressio/pull/513#discussion_r1050558365 from @fnrizzi:

it should not return 0 if i!=0 , because a vector has 1 column.

  return (i == 0) ? objectIn.length() : 1;

this PR makes presssio::ops::extent() consistently return 1 for over-the-rank extents and adds related unit tests for each TPL implementation.

fnrizzi commented 1 year ago

this is failing the CI ?

mzuzek commented 1 year ago

this is failing the CI ?

Yes... investigating what can be the cause.