PrestaShop / ADR

Architecture Decision Records for the PrestaShop project
11 stars 15 forks source link

0013 - Use TypeScript on the project #19

Closed NeOMakinG closed 3 years ago

NeOMakinG commented 3 years ago

Here is the TS proposal

matks commented 3 years ago

Question: what about the JS scripts where we use native JS components and jQuery? These files are not eligible to be written in TS so they will stay regular JS files?

NeOMakinG commented 3 years ago

Question: what about the JS scripts where we use native JS components and jQuery? These files are not eligible to be written in TS so they will stay regular JS files?

Every Vanilla stuffs and jQuery are usable inside typescript files without any problems !

Also, we would need to decide the scope of TS, I would say that only new files would be written using TS, and refacto smoothly and slowly other files, focusing important features such as grids

kpodemski commented 3 years ago

TypeScript is best what happened for js community in a long time. I'm 100% sure that in application where we want back-end architecture to be solid and mature, we should aim for same quality on front end.

Of course this requires more knowledge from potential contributor than before, but I think we have quite similar situation on back end.

So yeah, I definitely agree with TS in PS ;)

PierreRambaud commented 3 years ago

TypeScript is best what happened for js community in a long time. I'm 100% sure that in application where we want back-end architecture to be solid and mature, we should aim for same quality on front end.

Of course this requires more knowledge from potential contributor than before, but I think we have quite similar situation on back end.

So yeah, I definitely agree with TS in PS ;)

https://i.imgflip.com/1kxup2.jpg

PierreRambaud commented 3 years ago

@kpodemski just see you didn't have the maintainer access here. It's now ok :+1:

eternoendless commented 3 years ago

Shouldn't we ask the community what they think?