Migrate "Customer Service > Customer Service > List & Form" page

matks commented 6 years ago

Part of Symfony migration project Type: page

Status

Todo:

[x] Migrate page https://github.com/PrestaShop/PrestaShop/pull/14288

Check-List (copied from #13989)

App layer

Controller / routing

[ ] All controller actions are migrated and protected with @AdminSecurity annotations when eligible and @DemoRestricted annotations when eligible
[ ] All links targeting this page are updated: either using _legacy_link or updating the code
[ ] The new SF routes have _legacy_link and _legacy_parameters provided and explained
[ ] Controller catches Domain Exception and translate them nicely
[ ] Add/Edit controllers must catch global Exception in order to handle ModuleErrorException
Template
[ ] Twig templates must contain relevant blocks to allow partial extension by modules
[ ] Twig forms must have form_rest() and form_errors()
[ ] JS being used on the page can be used as enabled extensions and use a PageMap for selectors
[ ] Use @PrestaShop instead of PrestaShopBundle for template root path aliasing
Conventions
[ ] The new controller actions comply with our naming convention
[ ] The new SF routes names and paths comply with our naming convention
[ ] The new Twig template names comply actions with our naming convention
[ ] Created files (controller, JS assets, CSS assets and twig views) must be in the right folder following the convention
[ ] CSS being added must follow theme conventions

Core layer

[ ] Commands and Queries only use native types but internally use VOs
[ ] All Handlers must have an Interface
Conventions
[ ] The created SF service names comply with our naming convention
[ ] The created files must follow the folder convention (Domain, Core, Adapter...)

Polishing

[ ] The legacy controller and templates files are gone
[ ] If PR includes a new concept/mechanism, documentation must be written
[ ] JS and CSS assets must be compiled and up-to-date
[ ] License headers must be up-to-date
[ ] New hooks have been added to the hooks list and the SQL updates
[ ] Performance must be correct: page loading time, filtering/sorting/searching response time, actions response time

Testing

[ ] Commands and Queries are tested with Behat tests
[ ] Eligible Core classes are covered with unit tests*
[ ] Controller is covered with survival test
[ ] (soon) Controller is covered with E2E tests using puppeeter
[ ] If we break E2E tests because IDs change, we must update the E2E tests

*Eligible = easy to isolate and unit tests provide values (for example testing getters/setters is useless)

sarjon commented 5 years ago

@matks please assign this feature to me.

mrabsinthe commented 5 years ago

99% of our customers are ignoring the following message when receiving a message sent either from Orders/Messages or from Customer Service: "Please DO NOT reply directly to this email, we will not receive it. In order to reply, please use only the following link: https://etc.etc..." Is it possible that a direct reply will appear in thread under Customer Service? This could be seen with many support services (please reply above the line... etc.)

matks commented 5 years ago

99% of our customers are ignoring the following message when receiving a message sent either from Orders/Messages or from Customer Service: "Please DO NOT reply directly to this email, we will not receive it. In order to reply, please use only the following link: https://etc.etc..." Is it possible that a direct reply will appear in thread under Customer Service? This could be seen with many support services (please reply above the line... etc.)

You mean "the mail sent back by the customer appears on the page" ? Unfortunately this only works if the mail server you use (it can be gmail, it can be microsoft exchange ...) allows to retrieve such data :/ so this feature would be 100% dependent of the mail server allowing it ... and the ability of people to configure it correctly

That would be a good target for a module, 1 module for 1 mail service provider, but cannot be done in a generic mean unfortunately

PrestaShop / PrestaShop