PrestaShop / PrestaShop

PrestaShop is the universal open-source software platform to build your e-commerce solution.
https://www.prestashop-project.org/
Other
8.22k stars 4.81k forks source link

BO - Logs / the name and first name variables are not interpreted in the logs email #22091

Open SD1982 opened 3 years ago

SD1982 commented 3 years ago

Describe the bug

the name and first name variables are not interpreted in the logs email

Expected behavior

The varibles should be interpreted

Steps to Reproduce

Steps to reproduce the behavior:

PS => The SMTP parameters should be correctly set

  1. Go to Advanced parameters / logs
  2. Set the "minimum security level" to 1
  3. Make some action to generate log ( try to import a localisation pack for exemple)
  4. Go to your mail box and see error => The "firstname" and "lastname" variables are not interpreted

Screenshots image

Additional information

LouiseBonnard commented 3 years ago

You're right, thanks @SD1982, variables should be interpreted in the email. Yet, this email is intended for the merchant/employee so it is unnecessary to add the first and last names in each email. A simple Hi, (instead of Hi {firstname} {lastname},) in Emails.Body looks enough and less formal. ;-)

Here are the other emails (modern template) this change could be applied:

ghost commented 3 years ago

Hi @LouiseBonnard i made this one : https://github.com/PrestaShop/mjml-theme-converter/pull/11

PrestaEdit commented 2 years ago

The Pull Request seems merged, I think we can close this issue.

matks commented 2 years ago

I think we might need to re-build the mail theme using https://github.com/PrestaShop/mjml-theme-converter/ ?

florine2623 commented 10 months ago

In PS 8.1.x, the variables are not displayed :

Screenshot 2023-12-27 at 15 39 37