PrestaShop / PrestaShop

PrestaShop is the universal open-source software platform to build your e-commerce solution.
https://www.prestashop-project.org/
Other
8.23k stars 4.81k forks source link

Allow html when displaying customizations in the backoffice order page #22220

Closed unlocomqx closed 3 years ago

unlocomqx commented 3 years ago

Describe the bug

Customizations displayed by a module are not displayed correctly

Expected behavior

HTML should be allowed when displaying customizations because the customization is sanitized on save anyway and modules hooked to displayCustomization would need to display a html summary in most cases

Steps to Reproduce

You will need a module that is hook to displayCustomization and which is returning a html summary of the customization

Screenshots

image

It should be

image

Additional information

I will submit a PR to fix this

hibatallahAouadni commented 3 years ago

Hello @unlocomqx

Change id_module in ps_customized_data to the id of the customization_hook module (can be found in ps_module)

What do you mean by that? you mean I have to change id_module from the database? Did you upgrade your shop? if so, could you please tell which PS version you had and if this bug occured with your previous shop?

Thanks!

unlocomqx commented 3 years ago

@hibatallahAouadni Yes, it's normally done by a module where the module saves its ID in the the table ps_customized_data when it saves the customization. Then based on that ID, the displayCustomization hook is called and thus only the concerned module is invoked.

My PrestaShop version is 1.7.7.0 The bug didn't occur in the previous versions because html was allowed in the previous templates With the new twig templates, html is filtered when it comes to displaying customizations in the backoffice

hibatallahAouadni commented 3 years ago

Hello @unlocomqx

Well, I installed your module in PS1.7.6.9 and PS1.7.7.0, and I didn't see the difference. First, I couldn't add html code in Customization field (if it was text/file), see the attached screen record below:

- Text: https://drive.google.com/file/d/1n_99YP3oxNVfrfjxz7ZRJ_WXvn7jIdMS/view

- File: image

Second, I couldn't understand how your module works, could you please provide screen record.

Thanks!

unlocomqx commented 3 years ago

@hibatallahAouadni It's okay, we discussed the PR and it wasn't accepted, so I will close this issue I found another way to avoid this problem Kind regards