PrestaShop / PrestaShop

PrestaShop is the universal open-source software platform to build your e-commerce solution.
https://www.prestashop-project.org/
Other
8.19k stars 4.81k forks source link

Faceted search Module - Price filter work only on gross price (no discounted) #22621

Closed Sg-nipe closed 2 years ago

Sg-nipe commented 3 years ago

Describe the bug

When we try to apply price filter this work only on gross price, no on discounted price (made on products page, pricing tabs, specific price session).

Try to enable/disable

Steps to Reproduce

Steps to reproduce the behavior:

  1. Generate a specific price for a product
  2. Enable on Faceted search modules template the price filter
  3. Try to filter

Screenshots Before: 2020-12-29 17_45_21-Window

After (no more product of the first image): 2020-12-29 17_45_57-Window

Additional information

hibatallahAouadni commented 3 years ago

Hello @Sg-nipe

Thanks for your issue :slightly_smiling_face: I reproduced your issue with PS1.7.6.9 and only with FacetedSearch v3.7, cause with FacetedSearch v3.5 I didn't manage to reproduce it, see the attached screen record below:

https://drive.google.com/file/d/15ESPLMQAZvrLbWqzZNZF1WsKCeXJfaqY/view

I’ll add this to the debug backlog so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!

PS: you need to downgrade your PHP version to 7.2 cause it's not compatible with PS version, see our sysem requirements

Thank you

PierreRambaud commented 3 years ago

Seems to be a duplicate of #16822 :thinking:

hibatallahAouadni commented 3 years ago

Hello @PierreRambaud

I didn't manage to reproduce it with FacetedSearch v3.5 While #16822 I reproduced it with v3.5 So, I think it's related but not duplicated :wink: But, I will test your PR and see if it could fix both issues.

Thanks!

hibatallahAouadni commented 3 years ago

Hello @PierreRambaud

I tested your PR, I didn't encounter this issue neither #16822, see the attached screen record below:

https://drive.google.com/file/d/16I_06olq6KPyLzPJKUtnzjgW4Ncj9n5-/view

But, I encounter this problem, see the attached screen record below:

https://drive.google.com/file/d/152dmHzv-E9TpoMS0PAwdIqCE_Jbq0EJU/view

When I choose the price range from 1,251.000 to 1,500.000, I had no product displayed but the pagination indicates that there's a product and that's right cause the product should be displayed.

Could you please checked :slightly_smiling_face: Thanks!

PierreRambaud commented 3 years ago

Hello @PierreRambaud

I tested your PR, I didn't encounter this issue neither #16822, see the attached screen record below:

https://drive.google.com/file/d/16I_06olq6KPyLzPJKUtnzjgW4Ncj9n5-/view

But, I encounter this problem, see the attached screen record below:

https://drive.google.com/file/d/152dmHzv-E9TpoMS0PAwdIqCE_Jbq0EJU/view

When I choose the price range from 1,251.000 to 1,500.000, I had no product displayed but the pagination indicates that there's a product and that's right cause the product should be displayed.

Could you please checked Thanks!

This is a known issue :+1:

hibatallahAouadni commented 2 years ago

Hello everyone,

This issue has been fixed :tada:

image

Thanks!