BO - Tax rules - Exception thrown when trying to delete a country linked to the tax rule

[florine2623]

Prerequisites

• [X] I understand and accept the project's code of conduct.
• [X] I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add attachments

AdminTaxRulesGroupControllerCore::deleteTaxRule(): Argument #1 ($id_tax_rule_list) must be of type array, bool given, called in /controllers/admin/AdminTaxRulesGroupController.php on line 510

Not a regression, in PS 1.7.8.8 :

Expected behavior

Should not throw an error

Steps to reproduce

1. Go to BO > International > Taxes > Tax rules
2. Edit any tax rule
3. Click Bulk Action > Select All > Delete selected
4. Add a new tax rule with one country > Save and stay
5. See error

PrestaShop version(s) where the bug happened

8.1.0 beta

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

[matks]

@tleon starts it

[matks]

@florine2623 Hello! @tleon tried to reproduce this bug but could not observe it on localhost.

We think maybe it's the steps that maybe are not 100% clear:

Go to BO > International > Taxes > Tax rules Edit any tax rule Click Bulk Action > Delete selected See error

The 3rd step we think it means: "Go on the tax rules listing, tick 2 or 3 checkboxes then use the Bulk action "Delete" " but as @tleon mentions, the title of this ticket is "Exception thrown when trying to delete a country linked to the tax rule" . So maybe in fact you are deleting a country, not a tax rule?

Can you please help us 😉 ?

[florine2623]

Hello @tleon @matks ,

Sorry for the late answer 😅

I have updated the steps to reproduce the issue.

Here's a screenrecord :

https://github.com/PrestaShop/PrestaShop/assets/16019289/614c73dd-aa3d-433b-bed1-f11fe3b50a2c