search

PrestaShop / PrestaShop

PrestaShop is the universal open-source software platform to build your e-commerce solution.
https://www.prestashop-project.org/
Other
8.21k stars 4.81k forks source link

BO - Error while Upgrading some modules #34022

Closed aniszr closed 9 months ago

aniszr commented 1 year ago

Prerequisites

Describe the bug and add attachments

When you click on Upgrade on a module in BO you get an error even all the permissions to read/write are verified!

See attached screenschot:

- On Develop

image

- On 8.1.x

image

Only the module Autoupgrade was upgraded successfully :heavy_check_mark:

The problem concern some modules that I tried to upgrade:

  1. Product Comments

5.0.2 => 6.0.2 :white_check_mark: 5.0.3 => 6.0.0 :x: 5.0.3 => 6.0.2 :x: 5.0.2 => 6.0.0 => 6.0.3 :white_check_mark: 5.0.2 => 5.0.3 => 6.0.0 => 6.0.3 :white_check_mark:

  1. Mail alert

2.4.0 -> 2.4.2 :white_check_mark: 2.4.1 -> 2.4.2 :x:

  1. Link list

6.0.2 => 6.0.4 :white_check_mark: 6.0.3 => 6.0.4 :x:

  1. Faceted search

3.13.0 => 3.13.2 :white_check_mark: 3.13.1 => 3.13.2 :x: 5.0.2 => 5.0.3 => 6.0.3 :white_check_mark:

Expected behavior

All modules should be upgraded successfully from BO

Steps to reproduce

  1. Go to Modules > Module Manager
  2. Click on Updates tab
  3. Click on Upgrade button
  4. See Error

PrestaShop version(s) where the bug happened

8.1.x & develop

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

No response

hibatallahAouadni commented 1 year ago

PS: when I uninstall the version of productcomments 5.0.3 (installed by default), then download the same version 5.0.3 from github, install it, then upgrade it to 6.0.2 :heavy_check_mark: it's upgraded without any errors

leemyongpakvn commented 1 year ago

Both productcomments and ps_linklist are at "^6" after @jolelievre Update product comments in composer.lock for 8.1.x so we won't see problem with Upgrade from v5 to v6 with these 2 modules in 8.1.x any more. By the way, I think the problem comes from Upgrade module or some Core changes, not other modules. You can try with a fresh installation of 8.1.x, do upgrade other modules without Autoupgrade upgrade prior.

florine2623 commented 9 months ago

Hello @aniszr ,

I can't reproduce your issue anymore. It seems fixed.

On 8.1.x, all modules were successfully upgraded.

https://github.com/PrestaShop/PrestaShop/assets/16019289/0d1b0df2-dad4-4ee0-a689-9d07d59ea4e1

On develop, there were on errors, but eventually all module were successfully upgraded.

https://github.com/PrestaShop/PrestaShop/assets/16019289/efcb163a-00f8-44b6-b10a-163940eed76a

I'm closing the issue to avoid clogging the backlog. Thanks!