New page carriers - bugs

paulnoelcholot commented 3 weeks ago

Prerequisites

[X] I understand and accept the project's code of conduct.
[X] I have already searched in existing issues and found no previous report of this bug.

Describe the bug and add attachments

Bug 1 I edit an old carrier, if I want to add a new zone but I do not enter the cost, the name of the zone disappears.

Bug 2 I create a new carrier, if I want to add a new zone, I cannot enter a cost.

Bug3 If I want to put a logo greater than 8 Mb, I have an error 500

Bug 4 If I configure my carrier with maximum authorized order dimensions of 1cm x 1cm x 1cm. I can order an order greater than these dimensions if the weight of the order is less than the maximum authorized weight.

Bug 5 If the shipping costs are free, I cannot choose a delivery zone.

Bug 6 I can't save a carrier if all the required fields are not filled in. If I don't fill them in, I don't get an error message to tell me.

Expected behavior

No response

Steps to reproduce

Bug 1 : https://www.loom.com/share/c1ba7893e5174e9591dd4397f4f2d1f7

Bug 2 : https://www.loom.com/share/d42a86ca6d074792a49035b8d3a034db

Bug 3 : https://www.loom.com/share/a3f932975bbb4a1db1e712d5f3eaeac2

Bug 4 :

Bug 5 :

Bug 6 https://www.loom.com/share/581a1052cdc14effb8a4a8f3a5582d68

PrestaShop version(s) where the bug happened

develop

PHP version(s) where the bug happened

8.1

If your bug is related to a module, specify its name and its version

No response

Your company or customer's name goes here (if applicable).

No response

Hlavtox commented 3 weeks ago

@paulnoelcholot Bug 4 is not a bug, the carrier mechanism can't know what is the meaning of your combination. :-))) If you want these limitations to apply, you must fill out the product shipping dimensions on product detail.

matks commented 2 weeks ago

Thank you @Hlavtox and @paulnoelcholot for the detailed report ;)

MateoCastilloPS commented 1 week ago

@paulnoelcholot as you I was a victim of UX (as well as my teammates ^^') for the bug 2 you mention. Actually, it is not a bug, what happened is that you did not add the ranges that are needed for adding the prices... because probably you did not see the CTA. After discussing this UX issue with the product team we rearranged a little but this pricing section in order to improve the user journey.

Also, bug 5 is a consequence also of a quiproquo in the design, in the prototype it was shown that when free shipping toggle was activated it hid all the fields below (including the zones choice)

So in consequence we decided to make some updates to the UX and re-aranged the page to have:

First the user declares where he wants to ship (he chooses his zones)
Then the user sets his pricing configuration (decides if free shipping or not)
We moved the "edit ranges" CTA to have it as a form element aligned with the rest of actions
The pricing cards will appear only when the user will have added a a range

By doing this we think the user will understand better what to do, and like that if he wants a "free shipping" he will be still be able to choose his zones.

This will be updated on the upcoming PR's

PrestaShop / PrestaShop