search

PrestaShop / PrestaShop

PrestaShop is the universal open-source software platform to build your e-commerce solution.
https://www.prestashop-project.org/
Other
8.16k stars 4.81k forks source link

[BOOM-6115] Links of pagination are not clickable if the pagination is on a custom page #9557

Closed prestonBot closed 5 years ago

prestonBot commented 6 years ago

This issue has been migrated from the Forge. Read the original ticket here.

Hi
I've added the pagination to a module page like on the product list to show some feedback
all is ok, the html code is ok, the only problem is if I try to push on ex. the link "2" nothing happen (but the tag "a" html code is ok, the url is ok)

is it due from javascript code of the classic theme?

can help me to understand how to fix it?
it is useful for everyone use pagination in module pages

thanks

N/A

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

if I click on the url from chrome tool the page will be reloaded with the new url and the result is right

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Have you the same issue with this ticket: BOOM-5808?

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

hi
no it is different
I send you an email with an url to do a test

thanks

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

I sent you a video record by email.
Thanks to check and feedback.

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

with this code the link are ok

$('.pagination a:not(.disabled)').on('click', function(event)

{ event.preventDefault();

window.location.href = $(this).prop('href');

return false; }

);

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

I'm doing some tests
now I've removed that code
so you can check again

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

probably on these links there is a css or javascript block like

$('.pagination a').unbind('click');

or

.pagination a

{ pointer-events: none; }

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Have you made this modification in the template files?

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

no
I think it is present on the default theme.css or js file
I've tested removing all css and js code of my module for that page but those links are not clickable

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

the pagination is used on advanced search, and in those pages there are many codes,
perhaps they did not consider the use of pagination for other situations,
however if the html code is right but the links do not work it means that there is something that blocks them

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

I continue to do some tests, so now they will work

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Did you use a customized module module-maofreefeedback-feedback?

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

I use the controller for feedback.php
but it is not a problem, there are one css and one js files
I've removed those code but the problem continue to be present

using that js code works

but only because it circumvents that problem

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

So this issue is not related to the core Prestashop?
Is it all about your module?

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

it is the opposite
my module is not the problem
the problem is or css or js but on the Prestashop's theme

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

I think it is due from some limitations on pagination on product list
and if it is used on module page there are some blocks because the conditions are different
however all is ok only on the clicks

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Could you please provide us a test module to check it, so we can reproduce the issue.

Thanks & Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

hi
modules sent

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

I just received the email.
I will check and feedback.

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

There is an error occurred when uploading your module.
I' m using PrestaShop 1.7.4.2.
I attached a video record.
Manage installed modules • 1724ppp.webm
Thanks to check and feedback.

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

ok wait a moment

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Thanks!
Waiting for your feedback.

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

I tried on my local server and it is ok when I install it

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Sorry, always the same problem.

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

It is so strange
however try to install it from ftp instead of back-office

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Ok, I just installed your module.
I get this error in the FO.

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

ok thanks
the problem is due from currency table
on the 1.7 is without some fields like format

I'll find a new solution and resend the zip to you

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Thanks!
Waiting for your feedback.

Best regards, Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

fixed
use the second file
bye

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Thanks for reporting.
I close the ticket, feel free to open a new one when needed.

Best regards,
Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi
why do you close the ticket?
I've sent you the correct zip to reproduce the bug

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

sent it again now

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

Do you have the same issue?

Best regards,
Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

yes
I fix the problem using 3 lines of javascript code, but without it I cannot redirect on the other paginations after the click
the zip sent, is without these javascript code to reproduce this error

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

I did not manage to reproduce the issue with PS 1.7.4.2 and your module
I attached a video record.
Aug 1 2018 4_33 PM.webm
Thanks to check and feedback.

Best regards,
Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi
sorry but you are wrong
the product pagination is ok, the problem is on the pagination used on the controller of a module

go to the configuration page of my module and set instead of 40, 3 feedback for page
then push on the button of the module "see all feedback"
now you will be in the feedback list where the pagination is active
at this moment you need to add 4 or 5 or 7 feedback from its form pushing on the red button
then go to its configuration page and active them
return on the feedback list and push on the voices of the pagination

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

I received that , but the module "productcomments" does not exist.

Best regards,
Khouloud

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi
I know but this is not necessary (with my module you can add generic feedback)
follow my suggestion:

now go to the front-office and search on the homepage my block, then push on its button
now you will be on the feedback page
add from here 5 feedback
then go in its configuration page to enable them
the return on the previous feedbackpage and you will find the paginations

prestonBot commented 6 years ago

This comment has been migrated from the Forge. Read the original comment here.

Hi maofree,

I manage to reproduce the issue with the last version PS:1.7.42
We will see how to fix it.

Best regards,
Khouloud

marionf commented 5 years ago

@khouloudbelguith Could you try to reproduce this issue with 1.7.6.0 ?

khouloudbelguith commented 5 years ago

Hi @marionf,

Using the custom module sent by @maofree with PS1.7.6.0beta1, I have an issue image @maofree do you still have the same issue with PS1.7.6.0? I tried with your module => error Thanks to check & feedback

maofree commented 5 years ago

Hi at this moment I've no tested the 1.7.6

khouloudbelguith commented 5 years ago

Hi @maofree,

Thanks to check with PS1.7.6.0 & feedback.

TheElixZammuto commented 5 years ago

Having the same problem (with a custom module) on PS1.7.6.1 Removing js-search-link class from template file _partials/pagination.tpl removes the issue

khouloudbelguith commented 5 years ago

@TheElixZammuto, could you please provide me the module to test it. This is a public space. You can provide me the module by email. My address mail: khouloud.belguith@prestashop.com Let's be safe!

Thanks!

khouloudbelguith commented 5 years ago

Hi @maofree, @TheElixZammuto,

Any news About this issue?

Thanks!

maofree commented 5 years ago

hi I don't know what to tell you because I don't always have time to check if an error is present in the various versions of prestashop, I don't think for you it is complicated to verify it

khouloudbelguith commented 5 years ago

Hi @maofree,

I tried to install the module maofreefeedback with PS1.7.6.0rc1 => OK. But in the FO, there is no block to add any feedback. In the BO => Design => Positions => I don't have any hook transplant to this module https://drive.google.com/file/d/16anAwKh5Sutuc4eOmZM4RZRciTvrnGXl/view

Thanks!

maofree commented 5 years ago

look at this site https://www.bottiglioni.it/accessori-bagno/ at the bottom you will see the carousel in the homepage, anche it will be present also in the left column on the category pages and in the tab of the product pages the push on the button to see all feedback and you will find a button to add new feedback the page is similar to this one https://www.bottiglioni.it/accessori-bagno/commenti

khouloudbelguith commented 5 years ago

@maofree, what the exact version PrestaShop did you use? Now, in your shop, links of pagination are clickable: https://www.bottiglioni.it/accessori-bagno/commenti

Thanks!