PrestaShop / TopTranslators

Top translators tribute page
https://translators.prestashop-project.org/
0 stars 3 forks source link

Build website from Github Actions #52

Closed Progi1984 closed 1 year ago

Progi1984 commented 1 year ago

@eternoendless Can you tell me why the repository has been moved to PrestaShopCorp Org ?

Progi1984 commented 1 year ago

@PrestaShopCorp/core & @djodjo3 Migrated from Jenkins to Github Actions as promised ;)

eternoendless commented 1 year ago

@Progi1984 No idea, probably because it's private (back when we weren't allowed to have private repos in the PS org). IMO it should be made public and moved back to PrestaShop org. Is there any kind of secret stored in the repo or in its history?

Progi1984 commented 1 year ago

@eternoendless I check with multiples tools and not found any kind of secret stored in the repo or in its history.

eternoendless commented 1 year ago

In that case we can make it public and move it to the PrestaShop org

Progi1984 commented 1 year ago

I let you do it @eternoendless. I have no rights.

Progi1984 commented 1 year ago

Thanks @eternoendless :)

No it's time to review @PrestaShop/committers & @PrestaShop/prestashop-core-developers

Progi1984 commented 1 year ago

Hi @PrestaShop/committers, I have one approval for @nicosomb. Can I have a second review when you will have some availability, plz ? Thanks

Progi1984 commented 1 year ago

@ga-devfront Hi, Docker is not used by CD tool so we remove as it is not useful.

I do the same thing in PrestaShop/TopContributors#85

Progi1984 commented 1 year ago

Go for merge

nicosomb commented 1 year ago

Thank you @Progi1984 !