search

PrestaShop / TopTranslators

Top translators tribute page
https://translators.prestashop-project.org/
0 stars 3 forks source link

Support build using Node 16 #58

Closed eternoendless closed 9 months ago

eternoendless commented 11 months ago
Questions Answers
Description? Updated everything necessary to make this run with Node 16 (and hopefully fix the build)
Type? bug fix
Sponsor company PrestaShop SA
eternoendless commented 11 months ago

It appears that we've entered in dependency hell - webpack will have to be updated alongside its dependencies. Feel free to continue this PR!

matks commented 11 months ago

It appears that we've entered in dependency hell - webpack will have to be updated alongside its dependencies. Feel free to continue this PR!

Is webpack needed at all?

If I look at https://translators.prestashop.com/ I see a static page with a "See more" CTA. I see nothing else moving.

The number of NPM dependencies in this file do not see to match the complexity of the application in the end. Even Redux and React are required, and I do not see any relevant usage of them. Nothing "reactive".

eternoendless commented 11 months ago

I agree that the way it was built clearly seems over-engineered for a modest one pager. However, the alternatives that I see are:

  1. Rewrite it using Hugo (likely the simplest choice)
  2. Rewrite it using the same stack as Top Contributors (Nuxt + Vue)

Both of them will require some work, but I don't know if it would be more or less than fixing Webpack.

matks commented 9 months ago

Hi @eternoendless it looks like we're going to be able to solve this problem with https://github.com/PrestaShop/TopTranslators/pull/68#issuecomment-1769242772 so I close this PR