PrestaShop / dateofdelivery

Displays an approximate date of delivery
http://www.prestashop.com
Academic Free License v3.0
0 stars 7 forks source link

Make dateofdelivery compatible with PrestaShop 1.7 #19

Open rdy4ever opened 5 years ago

rdy4ever commented 5 years ago

Describe the bug The native module dateofdelivery doesn't work. I've installed it on a fresh 1.7.5.0-beta (as well as my shop on 1.7.4.3), configured it but it just doesn't show the estimated date of delivery in the order page, in $hookDisplayBeforeCarrier, as it should.

To Reproduce Steps to reproduce the behavior:

  1. Install dateofdelivery module and configure it for one carrier
  2. Go to shop and add a product to cart. Go to checkout.
  3. Complete all checkout steps up to delivery step
  4. In delivery step, there's nothing displayed in $hookDisplayBeforeCarrier

Screenshots If applicable, add screenshots or screenrecords to help explain your problem. image

image

capture d'écran_2115

Additionnal information PrestaShop version: 1.7.4.3, 1.7.5.0-beta PHP version: N/A

khouloudbelguith commented 5 years ago

Hi @rdy4ever,

Thanks for your report. Yes, we are aware of this issue. I checked with PS 1.7.5.0beta1 & PS1.7.4.4 & the dateofdelivery module v2.0.1, it doesn't work. In FO, the module does not work, it does not display delivery time according to the module Date of delivery but according to what has been defined in the Transporters tab. @BilalDr what do you think, it is a native module? Thanks!

BilalDr commented 5 years ago

Hi @rdy4ever, Indeed, the module dateofdelivery doesn't work on Prestashop 1.7.5 beta and 1.7.4.3. It's a native module and it needs to be reworked to come back on Prestashop software.

radar6 commented 5 years ago

Still awaiting this module :)

matks commented 4 years ago

@marionf I tried to install this module, but in my Module Catalog I cannot find it. I type "date", "delivery", I cant find it. Can you have a look ? Maybe it was disabled for recent versions

marionf commented 4 years ago

@matks Yes, it's only avaible from 1.5.6.1 to 1.7.1.0

capture d'écran_2085

matks commented 4 years ago

@marionf Then if it is not available for PS > 1.7.1, is this issue relevant ? 🤔 Or is this issue in fact "fix the dateofdelivery module to make it work with latest PS versions" ?

marionf commented 4 years ago

I think the idea is to make it work with PrestaShop 1.7 If I remember well, the module wasn't displayed in FO because it has never been integrated with Classic theme So, maybe it needs some mockups

TristanLDD commented 4 years ago

From a UX point of vue, displaying the date of delivery in the checkout process is a strong reinsurance element, so in my opinion this module has a real value in terms of conversion.

I can make new mockups for classic theme but first we should take the decision whether or not we want to fix the module for 1.7.4.3+
@Coline is it a go or no go ? :)

colinegin commented 4 years ago

Yes this is a great idea, i'm all for it ! Do you think there's a lot of rework in terms of design ? In terms of features, I would recommend to stay iso as today, I can write down some specs based on the current documentation. About compatibility, depending on what technical changes are done in the module, it might be 1.7.6+, but we'll discuss this with a dev.

Thanks !

TristanLDD commented 4 years ago

@colinegin Ok !
Not much work needed on design, the module adds a little bit of text in the delivery part of the checkout. Looks like this in 1.6 : capture d'écran_2115

I'll update the mockup for classic theme here soon.

colinegin commented 4 years ago

You are my hero !

TristanLDD commented 4 years ago

Here's the mockup for Classic thème:

Delivery Date

colinegin commented 4 years ago

Better late than never ! Here are the specifications for the date of delivery module to be able to make it compatible with PS 1.7 : https://github.com/PrestaShop/prestashop-specs/blob/master/modules/dateofdelivery.md

Thanks @rdy4ever for raising this issue !