PrestaShop / docker

🐳
https://hub.docker.com/r/prestashop/prestashop/
MIT License
263 stars 181 forks source link

PS_HANDLE_DYNAMIC_DOMAIN ends up in error for 1.7-7.2-fpm #214

Open elboletaire opened 4 years ago

elboletaire commented 4 years ago

When setting PS_HANDLE_DYNAMIC_DOMAIN to true, the docker image ends up failing with the following error:

sed: can't read /conf-available/docker-php.conf: No such file or directory

Tried under prestashop/prestashop:1.7-7.2-fpm, but the error may be in other images as well, as the base files are the same for (most of) the prestashop docker images.

botnyx commented 3 years ago

i can confirm this issue.

jerryhopper commented 3 years ago

confirmed, the image is acting real weird when using enviroment-variables - especially when using PS_HANDLE_DYNAMIC_DOMAIN

prestashop_web2 |
prestashop_web2 | * Setting up install lock file...
prestashop_web2 |
prestashop_web2 | * Reapplying PrestaShop files for enabled volumes ...
prestashop_web2 |
prestashop_web2 | * No pre-install script found, let's continue...
prestashop_web2 | sed: can't read /conf-available/docker-php.conf: No such file or directory
prestashop_web2 |
prestashop_web2 | * Another setup is currently running...
prestashop_web2 |
prestashop_web2 | * Another setup is currently running...
prestashop_web2 |
prestashop_web2 | * Another setup is currently running...
prestashop_web2 |
prestashop_web2 | * Another setup is currently running...
prestashop_web2 |
prestashop_web2 | * Another setup is currently running...
prestashop_web2 |
prestashop_web2 | * Another setup is currently running...
PierreRambaud commented 3 years ago

We will try to fix it as soon as possible. Feel free to create a pull request if you have time to do it :)

elboletaire commented 3 years ago

I'm tired of creating pull requests and issues for prestashop and you just ignoring them for years. I won't close this one, but I'm unsubscribing, so don't expect me to answer again.

PierreRambaud commented 3 years ago

I'm tired of creating pull requests and issues for prestashop and you just ignoring them for years. I won't close this one, but I'm unsubscribing, so don't expect me to answer again.

I see only two pull requests from you on the PrestaShop org :sweat_smile: I agree about the closed one, it took too much time to get an answer from the team. But we can easily review and merge PR on this repository.

elboletaire commented 3 years ago

I said pr and issues ;)

PierreRambaud commented 3 years ago

I said pr and issues ;)

We never ignored issues, we can't just do everything for everyone. We are a really (really really) little team for a lot of projects, all repositories, tools, slack, and other things are managed by only 9 people, if people need something specific, they are able to create a pull request or hire a developer to do it.

elboletaire commented 3 years ago

Maybe you're the ones who should consider hiring a developer 😉

PierreRambaud commented 3 years ago

Maybe you're the ones who should consider hiring a developer

Please, keep in mind, this is an open source project :)

viktor1265 commented 3 years ago

2021 and I see this problem)

matks commented 3 years ago

@viktor1265 Unfortunately we already have a ton of work to do on other topics so we cannot find time to explore this topic. 😞

If you can help us, that would be amazing! 😉