PrestaShop / docker

🐳
https://hub.docker.com/r/prestashop/prestashop/
MIT License
257 stars 176 forks source link

Upgrade memory_limit from 256M to 512M #347

Closed hugofintecture closed 1 year ago

hugofintecture commented 1 year ago
Questions Answers
Description? Upgrade memory_limit from 256M to 512M to avoid some "Error: Allowed memory size"
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? no
Sponsor company Fintecture
How to test? Nothing should change

We think it's better for development purposes but maybe your prefer to follow this line from "The more the merrier. We recommend setting the memory allocation per script (memory_limit) to a minimum of 256M."?

kpodemski commented 1 year ago

@jolelievre publish action doesn't work because of the login/password, I think you have worked on this thing? also, should it be part of every PR?

jolelievre commented 1 year ago

@kpodemski yes it's because the secrets are set on the Organisation level and can only be accessed for PRs belonging to the repository only It doesn't work for a PR which source branch comes from a fork But it should work once it's merged on master

matks commented 1 year ago

@kpodemski yes it's because the secrets are set on the Organisation level and can only be accessed for PRs belonging to the repository only It doesn't work for a PR which source branch comes from a fork But it should work once it's merged on master

Then we should modify the GH Action to only run after a merge in the branch, not for pull requests

matks commented 1 year ago

Thank you @hugofintecture