PrestaShop / docs

PrestaShop technical documentation
https://devdocs.prestashop-project.org/
Other
117 stars 466 forks source link

Module naming conventions should allow underscore #1722

Open madsoliver opened 10 months ago

madsoliver commented 10 months ago

In devdocs Module naming convention it is stated that:

I suggest that the convention instead should be something like:

Why allow underscores?

Also discussed on slack

Hlavtox commented 10 months ago

+1 I never understood who came with this thing, completely breaking the ecosystem and conventions. (If native modules were not prefixed with ps_ than maybe. :-))

Related to https://github.com/PrestaShop/PrestaShop/issues/23717 Latest info from Pablo https://github.com/PrestaShop/PrestaShop/issues/23717#issuecomment-1651560654

madsoliver commented 9 months ago

I really hope we can sort this out one way or another 🙂 Just imagine how many modules that have underscores in their names. Changing name for modules is not a small task, neither for the developers, nor for the merchants. As far as I know there is no automatic way to upgrade from _mymodule to mymodule, so the merchant would need to uninstall and install. Also, think about all configuration values, tables, file-paths, all defined by the module name. It means ALOT of migration needs to be done for ALOT of modules.

And for what?

I also agree with @Hlavtox comment about convention. AFAIK there was no module naming convention before, so back in time, I just read between the lines that _one should use underscores, such as using company_module, just like the native psmodules did and still does. And I still think that should be the convention 😉

I understand there might be some technical issues with translation domains, but I think maybe it no longer is the case?