search

PrestaShop / example-modules

Example PrestaShop modules
Academic Free License v3.0
177 stars 118 forks source link

DemoSymfonyForm is not compatible with PS 8.0.x #103

Closed leemyongpakvn closed 2 years ago

leemyongpakvn commented 2 years ago
Questions Answers
Description? TextWithUnitType::class is not found in PS 8.0.x
'PrestaShopBundle:Admin/TwigTemplateForm:prestashop_ui_kit.html.twig' is not valid in PS 8.0.x either.
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes {paste the issue here}.
How to test? Due to core updates in 8.0
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.
kpodemski commented 2 years ago

Hi @leemyongpakvn

You're right. It is probably better to simply update the module. I was planning to do the overview of the modules in the upcoming weeks. I need to discuss it with other maintainers, but I think the goal of this repo should be to present the latest possibilities of the software, which means support for the latest major version (which hopefully will be v8 in a few weeks :))

leemyongpakvn commented 2 years ago

@kpodemski OK, I have just made an PR https://github.com/PrestaShop/example-modules/pull/104 that update this module to be compatible with PS 8.0.x only, maybe @okom3pom could improve it more. I wish we could find a way to support both PS 1.7.8.x and PS 8.0.x.

kpodemski commented 2 years ago

Closed in favor of #104