search

PrestaShop / example-modules

Example PrestaShop modules
Academic Free License v3.0
177 stars 118 forks source link

Demodoctrine: nullable Quote's content for nonDefault language #105

Closed leemyongpakvn closed 2 years ago

leemyongpakvn commented 2 years ago
Questions Answers
Description? Switch QuoteLang entity's content to nullable field and using nullable string.
Change QuoteLang table structure in data/install.sql accordingly.
Add a screnshot for better view
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes issues 68
How to test? After apply PR:
reset module to allow table quote_lang content nullable;
add a new quote with empty content for default language to make sure the required validator still work;
then fill content for default language and save to check if null content for non default language is allowed.
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.
matks commented 2 years ago

@mflasquin Can you confirm you tested this PR and it's OK ? :)