search

PrestaShop / example-modules

Example PrestaShop modules
Academic Free License v3.0
177 stars 118 forks source link

set demomultistoreform module's max PS version to current version #96

Closed matthieu-rolland closed 2 years ago

matthieu-rolland commented 2 years ago
Questions Answers
Description? The demo multistore module wouldn't install itself due to max ps compatibility being 1.7.8.0, this PR sets the max version to current version (just like other example modules)
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Copy the demomultistoreform module in your modules folder and try installing it, before this PR you will have an error, with this PR it works
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.
kpodemski commented 2 years ago

@matthieu-rolland

it's better to set the maximum version explicitly, we should recommend best practices to developers through these example modules, and it's one of them

just being said, it's either 1.7.99.99 or 8.99.99 if it's working in v8

I'll make sure to update it in other modules too

matthieu-rolland commented 2 years ago

good idea @kpodemski 👍

I updated the values for example modules that I'm confident are still compatible with prestashop v8