search

PrestaShop / ganalytics

Gain clear insights into important metrics about your customers, using Google Analytics in PrestaShop 1.6.
11 stars 43 forks source link

Price format and json encoded texts? #108

Open Piszi opened 6 years ago

Piszi commented 6 years ago

Hello,

I was going through the code of v. 2.3.4 after we saw wrong data in GA Conversions and I saw this: 'price' => number_format($product['price'], 2, ',') I belive this is the wrong format for GA because this will return for example this: 1,000.00 and GA iterpret this as 1 instead of 1000. According to Google the correct format would be 1000.00 so without the comma because GA does not respect currency formatting.

Can you please tell why you choose this formating for the price?

And at the same place I don't really understand why are the names json encoded. This will result in unreadable names if you have UTF-8 chars in your names like: í,é,á,ő,ű,ú etc..

Is there a reason for json encodeing?

sweetyandlatina commented 6 years ago

Excuse me, I do not understand anything about programming or what you are writing me about. If there is a problem with any price, I do not know why it happens, I just put the prices correctly with cents, if applicable or without cents and I have not touched anything that has to do with the default template that comes when Prestashop is downloaded.

If you can give me a solution that I can configure in a simple way, I will gladly do it ----- Original Message ----- From: Piszi To: PrestaShop/ganalytics Cc: Subscribed Sent: Saturday, March 17, 2018 6:07 PM Subject: [PrestaShop/ganalytics] Price format and json encoded texts? (#108)

Hello,

I was going through the code of v. 2.3.4 after we saw wrong data in GA Conversions and I saw this: 'price' => number_format($product['price'], 2, ',') I belive this is the wrong format for GA because this will return for example this: 1,000.00 and GA iterpret this as 1 instead of 1000. According to Google the correct format would be 1000.00 so without the comma because GA does not respect currency formatting.

Can you please tell why you choose this formating for the price?

And at the same place I don't really understand why are the names json encoded. This will result in unreadable names if you have UTF-8 chars in your names like: í,é,á,ő,ű,ú etc..

Is there a reason for json encodeing?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

   Libre de virus. www.avg.com