PrestaShop / hummingbird

81 stars 76 forks source link

[RESPONSIVE - My account Page] Credit slips #29

Closed prestascott closed 2 years ago

prestascott commented 3 years ago

Epic: https://github.com/PrestaShop/theme-refacto/issues/2 Desktop's issue: https://github.com/PrestaShop/theme-refacto/issues/23

Link to Figma prototype

UX and design explanations

Mockups

Credit slips responsive - credit slips

Empty credit slips responsive - empty credit slips

SharakPL commented 2 years ago

Could someone explain what the heck does credit slip even mean? What generates it? Polish translation for it is meaningless. Even Google translates it as 'karta kredytowa' which means 'credit card' - doesn't seem accurate. It looks like something used only in some countries, like Checks module. Maybe it should be disabled by default or at least provide an option to disable it.

NeOMakinG commented 2 years ago

Credit slips are generated when you got a refund or a partial refund, it's a proof of the refund, check inside an paid order in the BO, click on "Partial refund" and you'll be able to refund a product and generate a credit slip

adamus007p commented 2 years ago

A credit slip is the same as a credit note. [US]

A credit note is a piece of paper that a shop gives you when you return goods that you have bought from it. It states that you are entitled to take goods of the same value without paying for them. [British]

What it the main English language version in Prestashop ( US or British) ?

I used to see more credit note then credit slip.

In Polish: Nota kredytowa, inaczej nota uznaniowa (ang. credit note) – pisemny dokument wystawiony przez wierzyciela informujący dłużnika o umorzeniu określonej należności. Przykładem jest wystawienie noty kredytowej przez dostawcę dla nabywcy jeżeli nastąpił błąd w fakturze, zwrot towarów lub ich uszkodzenie. https://pl.wikipedia.org/wiki/Nota_kredytowa

SharakPL commented 2 years ago

Then why is it called Credit slips and not Refunds or Returns. Even Google doesn't know what credit slip really is 😂

NeOMakinG commented 2 years ago

image

Looks like googe knows, this is the right name, we could have use Credit Note too

Because it's not a refund, it's a receipt of that refund

Anyway, ping @PrestaShop/product-team, see the discussion, if you think we should change this naming, just tell us

adamus007p commented 2 years ago

I see that this is completely different translation in Polish. Credit note - faktura korygująca and possible in different countries too.

Anyway in that links in EU there is a term credit note, not credit slip.

But in Polish it can be other meaning for this.

Beside that I know Prestashop keep very weird and old things and names like order states which make a mess.

https://poradnikprzedsiebiorcy.pl/-credit-note-w-wnt-co-to-jest-i-jak-zaksiegowac-note-kredytowa

https://poradnikprzedsiebiorcy.pl/-credit-note-w-wnt-co-to-jest-i-jak-zaksiegowac-note-kredytowa

https://poradnikprzedsiebiorcy.pl/-faktura-korygujaca-a-nota-podstawowe-roznice

https://www.infakt.pl/blog/faktura-korygujaca-nota-korygujaca-jaka-roznica/

What it the main English language version in Prestashop ( US or British) ?

SharakPL commented 2 years ago

What it the main English language version in Prestashop ( US or British) ?

French 😛

adamus007p commented 2 years ago

I was asking about English :P You can choose English during installation, so what it the default version?

SharakPL commented 2 years ago

Because it's not a refund, it's a receipt of that refund

You need to make a return:

  1. print a return form,
  2. fill it up and send back with all returned products

to get a refund:

  1. money returned
  2. invoice correction generated

and have credit note generated - still no idea what it's for, other than just a database record to have this return listed on my account... or is it the same as invoice correction?


Anyway seems to me credit slip is only the final step of whole process, so IMO it should be called Returns because that's the main theme here.

$my_account_urls has 4 items by default:

Nothing about Returns specifically and that's crucial part of every shop since every order can be returned.


customeraccount module uses this frase: Credit slips you have received after canceled orders. So is it also about partial returns or just complete order cancelation?

MatShir commented 2 years ago

There are definitely some wordings improvements, we can do here :) Thanks for bringing up the issue. We can also use credit note, or credit memo. We need to be careful if we change it, we will need to change the doc and wording into the software, many places where this wording is used :)

adamus007p commented 2 years ago

@SharakPL I need to install new presta and check it.

@SharakPL you mean change this name when customer is logged in?

If you meant that you are right. For non-business customer I believe credit note say nothing. Returns would be better and inside it it could you naming about credit notes. At least customer would know what could be expect inside.

SharakPL commented 2 years ago

I was asking about English :P You can choose English during installation, so what it the default version?

English | English | en - flag of USA English GB | English | gb - flag of GB

Most of the time I only use english as a 2nd language, but I'd rather use en with GB flag

kpodemski commented 2 years ago

@SharakPL

Credit slip is "potwierdzenie zwrotu".

You can read more about it here: https://doc.prestashop.com/pages/viewpage.action?pageId=29656382

It's not about invoicing, it's just a confirmation to the customer that products have been returned.

SharakPL commented 2 years ago

Thanks @kpodemski

Credit slip is "potwierdzenie zwrotu".

So "Return confirmations" then. IMO "Returns" (PL: "Zwroty") is enough for clients to know what this page is about :)

adamus007p commented 2 years ago

The question is whether it is really needed? Credit slips in the menu. Is the status in the order not enough or info there about return?

What is the purpose to keep it separate in credit sleeps and in order history?

Julievrz commented 2 years ago

I was asking about English :P You can choose English during installation, so what it the default version?

It's American English. :-)

MatShir commented 2 years ago

Let's not forget that the theme of the project is meant to be a generic theme. Depending on the business and the size of the shop, the uses can change. But it is true that a separate credit slip on the interface, which is itself connected to an order, is not necessarily the best UI to do. We copied the behavior from the classic theme, but maybe it is time to improve it. Are your feedback from merchant perspective? @prestascott perhaps we can have a look at some good ecommerce practices to find a quick win optimization ?

MatShir commented 2 years ago

@SharakPL

Credit slip is "potwierdzenie zwrotu".

You can read more about it here: https://doc.prestashop.com/pages/viewpage.action?pageId=29656382

It's not about invoicing, it's just a confirmation to the customer that products have been returned.

Maybe it is a French requirement, because credit note (credit Slip ^^) in our end is about financial paper proving that a refund has been or will be made. It is for accounting purposes for the merchant and also receipt document for the client's merchants. (more to read here https://sumup.co.uk/invoices/dictionary/credit-note/, I should have found a better source I know )

SharakPL commented 2 years ago

So it's an invoice correction then. Basically another invoice for the order, just stating what on the original invoice changed: old record and new record. What if there was no invoice for the order, like when invoices are disabled? Should it still generate an invoice correction?

MatShir commented 2 years ago

In theory, when the invoice is sent to client and If you want to do a correction, you should send a credit note for major changes in the invoices.

adamus007p commented 2 years ago

@MatShir I am writing from merchant and customer perspective. Maybe I am wrong, but there no sense to keep only credit notes separate from order. It could be together with order in history. This is a part of whole order process and everything could be in one place.

Is there any reason that it is separated?

MatShir commented 2 years ago

No particular reason, maybe just an old school layout 🤷

SharakPL commented 2 years ago

OK, so here's how it works in PL. If there's a mistake on the invoice (wrong VAT number, wrong address, etc.) or there was a change in value (change of price, added discount, partial or complete return, etc.) the seller have to make correction invoice that buyer has to sign and send back (not always necessary). Correction note (or as you call it credit slip) can be made only by the buyer and it only handles simple mistakes, like address, product names, etc. If there's a change in invoice value, so also for every partial or complete return, then correction invoice has to be created by the seller.

I guess this is one of the features that are very hard to setup for every country separately. Like Prestashop's B2B mode works only in France and maybe few other countries with similar configuration.

MatShir commented 2 years ago

OK, so here's how it works in PL. If there's a mistake on the invoice (wrong VAT number, wrong address, etc.) or there was a change in value (change of price, added discount, partial or complete return, etc.) the seller have to make correction invoice that buyer has to sign and send back (not always necessary).

This part is the same in France. This feature is missing in PrestaShop because the new invoice (correction invoice) need to be "linked" to the first one, saying it is a correction of the first invoice.

NeOMakinG commented 2 years ago

I guess this is done, if there are some things to polish, let's see this after product review

I'll create another dedicated issue about wording