search

PrestaShop / hummingbird

82 stars 76 forks source link

Reproducible installs with npm #480

Closed tswfi closed 1 year ago

tswfi commented 1 year ago

Use npm ci to install packages. This obeys package-lock.json.

Questions Answers
Description? Use npm ci to install packages. This is repeateable and obeys package-lock.json . See https://docs.npmjs.com/cli/v9/commands/npm-ci
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
Sponsor company
How to test? its a readme :)
tswfi commented 1 year ago

eh, node 14.. hmm

NeOMakinG commented 1 year ago

eh, node 14.. hmm

Pretty sure you can change it, the theme was running on node 18 a few months ago on my computer

tswfi commented 1 year ago

also rebased so that the new package-lock files are used

tswfi commented 1 year ago

Looking better

kpodemski commented 1 year ago

thanks @tswfi 💪🏻