PrestaShop / hummingbird

82 stars 76 forks source link

Fix: [FO]Carrier extra content not work on deliveryFormSelector change #496

Closed GytisZum closed 1 year ago

GytisZum commented 1 year ago
Questions Answers
Description? Previously delivery extra content was shown only on page load. Added Prestashop event for extra content to be dynamic, tried to recreate the slide down animation as close as in classic theme with content max-heigh property.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes https://github.com/PrestaShop/hummingbird/issues/478
How to test? Add product to cart. Sign in and complete step 1 and step 2 on checkout. On delivery option step select different deliveries. Make sure delivery option has module with has an hook displayCarrierExtraContent which add's extra content.

On page load: image

Selecting method without extra content: image

Selecting another method which has extra content: image

GytisZum commented 1 year ago

Hello,

Thank you for response and the video you provided, however I am unable to recreate same issue on different PrestaShop versions (8.1.0 | 8.0.2). Could you please confirm that assets was builded as this PR have style file which has to be compiled. From video you provided it looks like they are missing that stylesheet. If it is not the case could you please double check if it is not the cache issues. If issue still appears please provide me your environment you test with.

Please check and feedback Thank you!

hibatallahAouadni commented 1 year ago

Please find attached the module I used to test this PR (developed by @Hlavtox )

tox_extracarrier.zip

guizme555 commented 1 year ago

Hello @hibatallahAouadni , I just tested on the develop branch and it works well (and I did clear my browser cache). My configuration :

nicosomb commented 1 year ago

thank you @GytisZum !