PrestaShop / hummingbird

77 stars 73 forks source link

fix: multiple slider update on facetsearch #550

Closed tblivet closed 8 months ago

tblivet commented 11 months ago
Questions Answers
Description? Fix an issue when multiple sliders are presents on faceted search ( the price and product weight who show in slider mode )
Type? bug fix
BC breaks? no
Deprecations?
Fixed ticket? This fix is related to this previous fix https://github.com/PrestaShop/hummingbird/commit/81e820452d6a7685c1b47ec16a59d20b8e077575
Sponsor company @PrestaShopCorp
How to test? You have to add some weight on few products for example one with 1kg another with 2kg and another with 3kg after that you can go to ps_facetedsearch configuration module click on "Reconstruire l'index intégralement" after that you can access in FO the category that contains the products with different weights and check if the price and weight filter work well :)
florine2623 commented 11 months ago

Hello @tblivet ,

When I install the PR, I can't choose "Use this theme" option. I'm having this issue :

Screenshot 2023-10-02 at 16 21 34
tblivet commented 11 months ago

Hello @tblivet ,

When I install the PR, I can't choose "Use this theme" option. I'm having this issue : Screenshot 2023-10-02 at 16 21 34

Hello @florine2623, I don't know how you are testing the theme, but I think you have to compile the theme before testing it with the npm run build command.

florine2623 commented 11 months ago

Here's the command that I used :

cd themes
rm -rf hummingbird
git clone https://github.com/PrestaShop/hummingbird.git hummingbird
cd hummingbird
git prc origin 550 dev
cd _dev && npm i && npm run build

The PR is well installed, the theme is well installed. But when I try to apply it to my shop, I'm having an error.

https://github.com/PrestaShop/hummingbird/assets/16019289/a920b530-e8ab-4815-851e-d096bda036a1

leemyongpakvn commented 9 months ago

@florine2623

cd _dev && npm i && npm run build

There is no _dev directory in this repo, please follow how-to-build-assets. ;)