search

PrestaShop / hummingbird

77 stars 73 forks source link

Use scrollIntoView when paging, fixes #562 #563

Closed tswfi closed 9 months ago

tswfi commented 9 months ago
Questions Answers
Description? Instead of doing scrollTo(0,0) use scrollIntoView to get the section#products start to be visible.
Type? bug fix && improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #562
Sponsor company
How to test? See issue for steps for trying to replicate the original issue with firefox

WIP, still requires a css rule

tswfi commented 9 months ago

as noted by @Hlavtox here https://github.com/PrestaShop/hummingbird/issues/562#issuecomment-1819181912 the scrolling is not nice when choosing facets and after testing I agree.

Closing this as this requires a bit more thought on how to make this really nice.