search

PrestaShop / hummingbird

77 stars 73 forks source link

Change pager scrolling behaviour, Fixes #562 #565

Closed tswfi closed 7 months ago

tswfi commented 9 months ago
Questions Answers
Description? Change how pager links scroll back to top of the product list. Also remove scrolling when changing facets
Type? improvement
BC breaks? no (maybe? one class changed?)
Deprecations? no
Fixed ticket? Fixes #562
Sponsor company
How to test? Change facet filters => should not scroll so you can easily select other facets too. Use pager in product listing => should scroll to top (pretty consistently even with firefox)
tswfi commented 8 months ago

Cannot replicate on OSX chrome, did you also clear your browser cache (or force refresh)?

image

https://github.com/PrestaShop/hummingbird/assets/1352132/ede217de-d3c5-4563-ae0a-6ccf456990e2

There are some minor "jumps" as new things are added to the page (like the "remove this filtering facet" buttons above the products and "clear all" button above the facets, but those are outside of the scope).

florine2623 commented 8 months ago

Yes, i have updated my chrome to version 120.0.6099.129, empty cache and hard reload 🤔

Maybe another @PrestaShop/qa-functional could test it. In any case, it works well with Firefox. It just needs to be checked one more time on Chrome.

SharakPL commented 8 months ago

TBH I've never liked filters in the left column. It's too messed up. Would be much better to move it on top of the products list in the center column and categories block to the top.

tswfi commented 8 months ago

TBH I've never liked filters in the left column. It's too messed up. Would be much better to move it on top of the products list in the center column and categories block to the top.

A setting would be the best.. Some merchants have lots of filters and having them on top of the products is not that easy to style nicely. Preferably there should be at least three different ways to show the filters. 1) like now 2) above the products 3) as a "sliding panel" from a button

Anyway, changing the logic is out of scope for this pull request.

AureRita commented 7 months ago

Hi @tswfi

Thank you for your PR, I tested it and it seems to works in my case as you can see :

recording(80).webm

Tested on develop and 8.1.x. Because the PR seems to works as expected, It's QA :heavy_check_mark:

Thank you