productcomments - Make rating mandatory - Githubissues

PrestaShop / hummingbird

77 stars 73 forks source link

productcomments - Make rating mandatory #577

Closed leemyongpakvn closed 5 months ago

leemyongpakvn commented 7 months ago

Questions	Answers
Description?	Implementation of productcomments' MakeReviewMadatory for hummingbird
Type?	improvement
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes #PrestaShop/PrestaShop/issues/26001
Sponsor company	Your company or customer's name goes here (if applicable).
How to test?	Apply PR change then check to make sure Review with Empty title, author, description or NotChosen rating won't be accepted. (Don't forget to clone a clean develop branch of hummingbird, as well as clear browser cache, PS cache before testing ;)

leemyongpakvn commented 7 months ago

@paulnoelcholot Please recheck https://github.com/PrestaShop/productcomments/pull/197

AureRita commented 7 months ago

Hi @kpodemski,

The PR is now merged,

@leemyongpakvn can you apply your last changes on this PR ?

Thank you

leemyongpakva commented 7 months ago

@AureRita The last commit in https://github.com/PrestaShop/productcomments/pull/197 stays in module's JS. There is no change needed for theme.

leemyongpakva commented 6 months ago

@kpodemski The productcomments PR is now merged.

leemyongpakva commented 5 months ago

@AureRita We are in need or re-QA

AureRita commented 5 months ago

Hi @leemyongpakva

Thank you for your PR, I tested it and it seems to works as you can see :

recording(141).webm

Tested on develop and 8.1.x

Because the PR seems to works as expected, It's QA :heavy_check_mark:

Thank you