Closed kpodemski closed 3 months ago
For the first point, here is the current state (and in brackets what I propose):
autocomplete="email"
(=> autocomplete="username"
)autocomplete="current-password"
(=> keep the same value)autocomplete="username"
)autocomplete="new-password"
)autocomplete="username"
)autocomplete="new-password"
)autocomplete="new-password"
)autocomplete="off"
(=> autocomplete="username"
)autocomplete="off"
OR autocomplete="current-password"
)autocomplete="off"
(=> autocomplete="new-password"
OR keep the same value off
)Is it any good? I'm not sure which is preferable between "username" and "email".
Points 2, 3, 4, 5, 6, 7 and 9 seem good.
Point 8 ("Mark invalid fields for screen-readers") is not good.
I don't know about points 10 and 11.
I haven't checked in detail, but here's what emerges from a (very) quick analysis.
Hello @yannicka
I'm not sure which is preferable between "username" and "email".
I think it would be email, and from what I remember this was the main improvement I wanted to include to forms in Hummingbird.
I don't know about points 10 and 11.
10 - I think we're good. 11 - this is worth checking, every single action that takes time and is being sent via AJAX should indicate that something is going on, I think it works better in Hummingbird but I haven't checked everything
So:
We can also go a little further with the other autocomplete values for the first name, surname, address, postcode, telephone number, etc. (on PrestaShop code)
More details: https://evilmartians.com/chronicles/html-best-practices-for-login-and-signup-forms
Details to be specified.