search

PrestaShop / hummingbird

77 stars 73 forks source link

Fix missing add to wishlist button and modals backdrop #584

Closed SharakPL closed 7 months ago

SharakPL commented 7 months ago
Questions Answers
Description? #568 prevented Add to wishlist button from loading on product list and caused error thrown in the console. thumbnail-container needs to be back in its original place.
It temporary breaks the product rating, but this needs to be fixed in the productcomments module, where wrong selector is being used in js (fix: https://github.com/PrestaShop/productcomments/pull/198)
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? -
Sponsor company -
How to test? -

Before

obraz

After

obraz

SharakPL commented 7 months ago

Further changes will be needed inside the productcomments module to avoid this empty space when no rating is available. It's meant for absolutely positioned Classic verstion and it only changes visibility.

IMO it's not the best place for it in Hummingbird. Products without rating will have either big empty space or different position of price, quantity and button and there will be layout shifts all over the page. Maybe we should keep it on the product cover like in Classic, but rather as a single star with score in it eg. 4.5/5, instead of 5 stars.

SharakPL commented 7 months ago

Removed whitespaces and literals, fixed modal backdrop class - should be show (BS 5) instead of in (BS 3) to see actual backdrop:

Before

obraz

After

obraz

SharakPL commented 7 months ago

Thanks @AureRita