search

PrestaShop / hummingbird

77 stars 73 forks source link

Carrier extra content not visible when changing between order steps from "header" #589

Closed tswfi closed 7 months ago

tswfi commented 7 months ago

not sure yet what happens, but :

<div class="carrier__extra-content-wrapper  carrier__extra-content-wrapper--active  js-carrier-extra-content" style="max-height: 0px;">

is applied to all carriers, even the selected one. This makes it impossible to see the extra content for the selected carrier if you switch steps either from the links at top of the order flow or from the "edit shipping" button in order-summary from payment step.

Steps to reproduce: add carrier extra content (write a test module that adds something in the carrierExtraContent hook), activate "show order summary", go forward in the order process until on the payment step. now click on "shipping" from the links above or shipping method "edit" button in order-summary. Carrier selection is shown but extra content is not. switching carrier at this point does show it again (something somewhere calculates max-height for the div).

Hlavtox commented 7 months ago

➡️ last change was this - https://github.com/PrestaShop/hummingbird/pull/496/files

tswfi commented 7 months ago

uh, was I testing on an older version.. sorry for the noise. I'll close this and if I can replicate again I'll open new issues.

Hlavtox commented 7 months ago

@tswfi I don't know if that usecase is fixed, better verify it in the latest version please. :-)