PrestaShop / hummingbird

77 stars 73 forks source link

Templates: double quotes => single quote (for Smarty strings) #601

Closed yannicka closed 4 months ago

yannicka commented 5 months ago
Questions Answers
Description? Chunk of #593. Strings in Smarty templates all (or almost all) use single quotes instead of double quotes.
Type? refactor
BC breaks? no
Deprecations? no
Fixed ticket? N/A
Sponsor company N/A
How to test? Install the theme and browse the website.
kpodemski commented 5 months ago

@yannicka after the merge of one of your PRs there are some conflicts there :( probably it will be a bit of a pain since your previous PR changed spaces 😓

yannicka commented 5 months ago

Should be good ;)

kpodemski commented 4 months ago

@florine2623, could you check what the logs say? because this is just a generic error message

yannicka commented 4 months ago

For my part, I can install the theme with this modification, and the theme works.

If you activate debug mode, it will display more information.