search

PrestaShop / hummingbird

77 stars 73 forks source link

Fix logo size #606

Closed boherm closed 4 months ago

boherm commented 4 months ago
Questions Answers
Description? After tests review for https://github.com/PrestaShop/hummingbird/pull/600#pullrequestreview-1898190625,
we need to fix the logo size when the uploaded image is taller than longer.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Not yet.
Sponsor company PrestaShop SA
How to test? See @florine2623 review in https://github.com/PrestaShop/hummingbird/pull/600#pullrequestreview-1898190625

--

Additional info issue from the release tests

Here's the result :x:

https://github.com/PrestaShop/hummingbird/assets/16019289/c8d1d6ad-7f02-4b0f-9c68-51f09b7b150c

SharakPL commented 4 months ago

Like max-width: 150px; ?

Yes, but from my experience it should be around 250px

AureRita commented 4 months ago

Hi @boherm

Thank you for your PR, currently I tested it and, yes, the logo is a little bit smaller but I think it's not enought as you can see :

image

FYI : you can scroll under the logo

Can you correct it ?

Waiting for your feedback

boherm commented 4 months ago

Hi @AureRita, thanks for the review!

This is only on the homepage or on a specific page?

It looks like you haven't properly rebuild hummingbird theme or don't clear the browser cache. 🤔 Have you done this steps?

@SharakPL, @tblivet, So, do you prefer adding max-width: 250px; property and also removing .img-fluid (that is totally bypassed by this rule)?